Store mipmap levels in deferred texture image

src/image/SkImage_Gpu.cpp

 /*
  * Copyright 2012 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkAutoPixmapStorage.h"
 #include "GrCaps.h"
 #include "GrContext.h"
 #include "GrDrawContext.h"
 #include "GrImageIDTextureAdjuster.h"
 #include "effects/GrYUVEffect.h"
 #include "SkCanvas.h"
 #include "SkBitmapCache.h"
 #include "SkGrPixelRef.h"
 #include "SkGrPriv.h"
 #include "SkImage_Gpu.h"
+#include "SkMipMap.h"
 #include "SkPixelRef.h"
 
 SkImage_Gpu::SkImage_Gpu(int w, int h, uint32_t uniqueID, SkAlphaType at, GrTexture* tex,
                          SkBudgeted budgeted)
     : INHERITED(w, h, uniqueID)
     , fTexture(SkRef(tex))
     , fAlphaType(at)
     , fBudgeted(budgeted)
     , fAddedRasterVersionToCache(false)
 {
@@ skipping 312 matching lines @@
         // It contains fMipMapLevelCount elements.
         // That means this struct's size is not known at compile-time.
         MipMapLevelData fMipMapLevelData[1];
     };
     Data fData;
 
     friend class SkImage;
 };
 
 size_t SkImage::getDeferredTextureImageData(const GrContextThreadSafeProxy& proxy,
-                                            const DeferredTextureImageUsageParams[],
+                                            const DeferredTextureImageUsageParams params[],
                                             int paramCnt, void* buffer) const {
+    bool shouldUseMipMaps = false;
+    for (int currentParamIndex = paramCnt - 1; currentParamIndex >= 0; currentParamIndex--) {
+        const SkMatrix& currentMatrix = params[currentParamIndex].fMatrix;
+        SkFilterQuality currentFilterQuality = params[currentParamIndex].fQuality;
+
+        // Use mipmaps if either
+        // 1.) it is a perspective matrix, or
+        // 2.) the quality is med/high and the scale is < 1
+        if (currentMatrix.hasPerspective()) {
+            shouldUseMipMaps = true;
+        }
+        if (currentFilterQuality == kMedium_SkFilterQuality ||
+            currentFilterQuality == kHigh_SkFilterQuality) {
+            SkScalar minAxisScale = currentMatrix.getMinScale();
+            if (minAxisScale != -1.f) {

[ericrk, 2016/06/06 22:57:40]

nit - just && this and the following if to reduce nesting?

[cblume, 2016/06/08 17:50:33]

Done.

+                if (minAxisScale < 1.f) {
+                    shouldUseMipMaps = true;
+                }
+            }
+        }
+    }
+
     const bool fillMode = SkToBool(buffer);
     if (fillMode && !SkIsAlign8(reinterpret_cast<intptr_t>(buffer))) {
         return 0;
     }
 
     const int maxTextureSize = proxy.fCaps->maxTextureSize();
     if (width() > maxTextureSize || height() > maxTextureSize) {
         return 0;
     }
 
@@ skipping 21 matching lines @@
         info = SkImageInfo::MakeN32(this->width(), this->height(), at);
         pixelSize = SkAlign8(SkAutoPixmapStorage::AllocSize(info, nullptr));
         if (fillMode) {
             pixmap.alloc(info);
             if (!this->readPixels(pixmap, 0, 0, SkImage::kDisallow_CachingHint)) {
                 return 0;
             }
             SkASSERT(!pixmap.ctable());
         }
     }
+    SkAlphaType at = this->isOpaque() ? kOpaque_SkAlphaType : kPremul_SkAlphaType;
     int mipMapLevelCount = 1;
+    if (shouldUseMipMaps) {
+        mipMapLevelCount = SkMipMap::ComputeLevelCount(width(), height()) + 1;

[ericrk, 2016/06/06 22:57:40]

nit: thanks for fixing this up - please add a comment explaining the +1

[cblume, 2016/06/08 17:50:33]

Done.

+
+        // SkMipMap will generate

[ericrk, 2016/06/06 22:57:40]

nit: comment isn't finished?

[cblume, 2016/06/08 17:50:33]

Done.

+        for (int currentMipMapLevelIndex = mipMapLevelCount - 1; currentMipMapLevelIndex >= 0;
+             currentMipMapLevelIndex--) {
+            SkISize mipSize = SkMipMap::ComputeLevelSize(width(), height(), currentMipMapLevelIndex);
+            SkImageInfo mipInfo = SkImageInfo::MakeN32(mipSize.fWidth, mipSize.fHeight, at);
+            pixelSize += SkAlign8(SkAutoPixmapStorage::AllocSize(mipInfo, nullptr));

[ericrk, 2016/06/06 22:57:40]

This will add in the size of level 0... isn't level 0 already accounted for int
he above if/else (line 393/408) - should this loop be > 0?

[cblume, 2016/06/08 17:50:33]

We need both, I believe.

393/408 gets the size of the base level.
This loop gets the size of the generated (non-base) levels.
The 0 here refers to the index 0 of SkMipMap's generated stuff.

I originally wrote SkMipMap code which used 1-based indexing because all uses I
can think of will include the base level as index 0. But it is awkward to have
one special class with a special rule, so we got rid of it.

I believe my unfinished comment above (whoops) was supposed to describe that.

+        }
+    }
     size_t size = 0;
     size_t dtiSize = SkAlign8(sizeof(DeferredTextureImage));
     size += dtiSize;
     size += mipMapLevelCount * sizeof(DeferredTextureImage::MipMapLevelData);
     size_t pixelOffset = size;
     size += pixelSize;
     size_t ctOffset = size;
     size += ctSize;
     if (!fillMode) {
         return size;
@@ skipping 13 matching lines @@
     SkASSERT(info == pixmap.info());
     size_t rowBytes = pixmap.rowBytes();
     DeferredTextureImage* dti = new (buffer) DeferredTextureImage();
     dti->fContextUniqueID = proxy.fContextUniqueID;
     dti->fData.fInfo = info;
     dti->fData.fColorTableCnt = ctCount;
     dti->fData.fColorTableData = ct;
     dti->fData.fMipMapLevelCount = mipMapLevelCount;
     dti->fData.fMipMapLevelData[0].fPixelData = pixels;
     dti->fData.fMipMapLevelData[0].fRowBytes = rowBytes;
+
+    // Fill in the mipmap levels if they exist
+    intptr_t mipLevelPtr = bufferAsInt + pixelOffset;
+    if (shouldUseMipMaps) {
+        SkAutoTDelete<SkMipMap> mipmaps(SkMipMap::Build(pixmap, nullptr));
+        // SkMipMap holds only the mipmap levels it generates.
+        // A programmer can use the data they provided to SkMipMap::Build as level 0.
+        // So the SkMipMap provides levels 1-x but it stores them in its own
+        // range 0-(x-1).
+        // This iterates 1-x.
+        for (int currentMipMapLevelIndex = 1; currentMipMapLevelIndex < mipMapLevelCount;
+             currentMipMapLevelIndex++) {
+            SkISize prevMipSize = SkMipMap::ComputeLevelSize(width(), height(), currentMipMapLevelIndex - 1);
+            SkImageInfo prevMipInfo = SkImageInfo::MakeN32(prevMipSize.fWidth, prevMipSize.fHeight, at);
+            mipLevelPtr += SkAlign8(SkAutoPixmapStorage::AllocSize(prevMipInfo, nullptr));
+
+            SkMipMap::Level currentMipMapLevel;
+            mipmaps->getLevel(currentMipMapLevelIndex - 1, &currentMipMapLevel);
+            memcpy(reinterpret_cast<void*>(mipLevelPtr), currentMipMapLevel.fPixmap.addr(),
+                   currentMipMapLevel.fPixmap.getSafeSize());
+            dti->fData.fMipMapLevelData[currentMipMapLevelIndex].fPixelData =
+                reinterpret_cast<void*>(mipLevelPtr);
+            dti->fData.fMipMapLevelData[currentMipMapLevelIndex].fRowBytes =
+                currentMipMapLevel.fPixmap.rowBytes();
+        }
+    }
     return size;
 }
 
 sk_sp<SkImage> SkImage::MakeFromDeferredTextureImageData(GrContext* context, const void* data,
                                                          SkBudgeted budgeted) {
     if (!data) {
         return nullptr;
     }
     const DeferredTextureImage* dti = reinterpret_cast<const DeferredTextureImage*>(data);
 
     if (!context || context->uniqueID() != dti->fContextUniqueID) {
         return nullptr;
     }
     SkAutoTUnref<SkColorTable> colorTable;
     if (dti->fData.fColorTableCnt) {
         SkASSERT(dti->fData.fColorTableData);
         colorTable.reset(new SkColorTable(dti->fData.fColorTableData, dti->fData.fColorTableCnt));
     }
-    SkASSERT(dti->fData.fMipMapLevelCount == 1);
-    SkPixmap pixmap;
-    pixmap.reset(dti->fData.fInfo, dti->fData.fMipMapLevelData[0].fPixelData,
-                 dti->fData.fMipMapLevelData[0].fRowBytes, colorTable.get());
-    return SkImage::MakeTextureFromPixmap(context, pixmap, budgeted);
+    int mipLevelCount = dti->fData.fMipMapLevelCount;
+    SkASSERT(mipLevelCount >= 1);
+    if (mipLevelCount == 1) {
+        SkPixmap pixmap;
+        pixmap.reset(dti->fData.fInfo, dti->fData.fMipMapLevelData[0].fPixelData,
+                     dti->fData.fMipMapLevelData[0].fRowBytes, colorTable.get());
+        return SkImage::MakeTextureFromPixmap(context, pixmap, budgeted);
+    } else {
+        SkAutoTDeleteArray<GrMipLevel> texels(new GrMipLevel[mipLevelCount]);
+        for (int i = 0; i < mipLevelCount; i++) {
+            texels[i].fPixels = dti->fData.fMipMapLevelData[i].fPixelData;
+            texels[i].fRowBytes = dti->fData.fMipMapLevelData[i].fRowBytes;
+        }
+
+        return SkImage::MakeTextureFromMipMap(context, dti->fData.fInfo, texels.get(),
+                                              mipLevelCount, SkBudgeted::kYes);
+    }
 }
 
 ///////////////////////////////////////////////////////////////////////////////////////////////////
 
 GrTexture* GrDeepCopyTexture(GrTexture* src, SkBudgeted budgeted) {
     GrContext* ctx = src->getContext();
 
     GrSurfaceDesc desc = src->desc();
     GrTexture* dst = ctx->textureProvider()->createTexture(desc, budgeted, nullptr, 0);
     if (!dst) {
@@ skipping 13 matching lines @@
     if (!ctx) {
         return nullptr;
     }
     SkAutoTUnref<GrTexture> texture(GrUploadMipMapToTexture(ctx, info, texels, mipLevelCount));
     if (!texture) {
         return nullptr;
     }
     return sk_make_sp<SkImage_Gpu>(texture->width(), texture->height(), kNeedNewImageUniqueID,
                                    info.alphaType(), texture, budgeted);
 }