Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Unified Diff: chrome/common/variations/child_process_field_trial_syncer.cc

Issue 2034933002: Make field trials activated in the GPU process be reflected in browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/variations/child_process_field_trial_syncer.cc
diff --git a/chrome/common/variations/child_process_field_trial_syncer.cc b/chrome/common/variations/child_process_field_trial_syncer.cc
index 9a0b309481e4e4656296b4c3184e328a0bdec03e..a0ba93913c9682fda63243de7b177f819789a510 100644
--- a/chrome/common/variations/child_process_field_trial_syncer.cc
+++ b/chrome/common/variations/child_process_field_trial_syncer.cc
@@ -9,13 +9,13 @@
#include "base/base_switches.h"
#include "base/command_line.h"
-#include "chrome/common/render_messages.h"
#include "components/variations/variations_util.h"
namespace chrome_variations {
ChildProcessFieldTrialSyncer::ChildProcessFieldTrialSyncer(
- IPC::Sender* ipc_sender) : ipc_sender_(ipc_sender) {}
+ base::FieldTrialList::Observer* observer)
+ : observer_(observer) {}
ChildProcessFieldTrialSyncer::~ChildProcessFieldTrialSyncer() {}
@@ -25,7 +25,7 @@ void ChildProcessFieldTrialSyncer::InitFieldTrialObserving(
variations::SetVariationListCrashKeys();
// Listen for field trial activations to report them to the browser.
- base::FieldTrialList::AddObserver(this);
+ base::FieldTrialList::AddObserver(observer_);
// Some field trials may have been activated before this point. Notify the
// browser of these activations now. To detect these, take the set difference
@@ -43,7 +43,7 @@ void ChildProcessFieldTrialSyncer::InitFieldTrialObserving(
base::FieldTrialList::GetActiveFieldTrialGroups(&current_active_trials);
for (const auto& trial : current_active_trials) {
if (!ContainsKey(initially_active_trials_set, trial.trial_name))
- OnFieldTrialGroupFinalized(trial.trial_name, trial.group_name);
+ observer_->OnFieldTrialGroupFinalized(trial.trial_name, trial.group_name);
}
}
@@ -58,10 +58,4 @@ void ChildProcessFieldTrialSyncer::OnSetFieldTrialGroup(
variations::SetVariationListCrashKeys();
}
-void ChildProcessFieldTrialSyncer::OnFieldTrialGroupFinalized(
- const std::string& trial_name,
- const std::string& group_name) {
- ipc_sender_->Send(new ChromeViewHostMsg_FieldTrialActivated(trial_name));
-}
-
} // namespace chrome_variations

Powered by Google App Engine
This is Rietveld 408576698