Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8645)

Unified Diff: chrome/common/variations/child_process_field_trial_syncer_unittest.cc

Issue 2034933002: Make field trials activated in the GPU process be reflected in browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: IWYU Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/variations/child_process_field_trial_syncer_unittest.cc
diff --git a/chrome/common/variations/child_process_field_trial_syncer_unittest.cc b/chrome/common/variations/child_process_field_trial_syncer_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..7d1992a05597add9f1a4539fdaec93874823e7fc
--- /dev/null
+++ b/chrome/common/variations/child_process_field_trial_syncer_unittest.cc
@@ -0,0 +1,94 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/common/variations/child_process_field_trial_syncer.h"
+
+#include <string>
+#include <utility>
+#include <vector>
+
+#include "base/base_switches.h"
+#include "base/command_line.h"
+#include "base/message_loop/message_loop.h"
+#include "base/metrics/field_trial.h"
+#include "base/run_loop.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace chrome_variations {
+
+namespace {
+
+// TestFieldTrialObserver to listen to be notified by the child process syncer.
+class TestFieldTrialObserver : public base::FieldTrialList::Observer {
+ public:
+ TestFieldTrialObserver() {}
+ ~TestFieldTrialObserver() override {}
+
+ // base::FieldTrial::Observer:
+ void OnFieldTrialGroupFinalized(const std::string& trial_name,
+ const std::string& group_name) override {
+ observed_entries_.push_back(std::make_pair(trial_name, group_name));
+ }
+
+ size_t observed_entries_count() const { return observed_entries_.size(); }
+
+ std::pair<std::string, std::string> get_observed_entry(int i) const {
+ return observed_entries_[i];
+ }
+
+ private:
+ std::vector<std::pair<std::string, std::string>> observed_entries_;
+
+ DISALLOW_COPY_AND_ASSIGN(TestFieldTrialObserver);
+};
+
+// Needed because make_pair("a", "b") doesn't convert to std::string pair.
+std::pair<std::string, std::string> MakeStringPair(const std::string& a,
+ const std::string& b) {
+ return std::make_pair(a, b);
+}
+
+} // namespace
+
+TEST(ChildProcessFieldTrialSyncerTest, FieldTrialState) {
+ base::MessageLoop message_loop;
+ base::FieldTrialList field_trial_list(nullptr);
+
+ base::FieldTrial* trial1 = base::FieldTrialList::CreateFieldTrial("A", "G1");
+ base::FieldTrial* trial2 = base::FieldTrialList::CreateFieldTrial("B", "G2");
+ base::FieldTrial* trial3 = base::FieldTrialList::CreateFieldTrial("C", "G3");
+ // Activate trial3 before command line is produced.
+ trial1->group();
+
+ std::string states_string;
+ base::FieldTrialList::AllStatesToString(&states_string);
+
+ base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
+ switches::kForceFieldTrials, states_string);
+ EXPECT_EQ("*A/G1/B/G2/C/G3/", states_string);
+
+ // Active trial 2 before creating the syncer.
+ trial2->group();
+
+ TestFieldTrialObserver observer;
+ ChildProcessFieldTrialSyncer syncer(&observer);
+ syncer.InitFieldTrialObserving(*base::CommandLine::ForCurrentProcess());
+
+ // The observer should be notified of activated entries that were not activate
+ // on the command line. In this case, trial 2. (Trial 1 was already active via
+ // command line and so its state shouldn't be notified.)
+ ASSERT_EQ(1U, observer.observed_entries_count());
+ EXPECT_EQ(MakeStringPair("B", "G2"), observer.get_observed_entry(0));
+
+ // Now, activate trial 3, which should also get reflected.
+ trial3->group();
+ // Notifications from field trial activation actually happen via posted tasks,
+ // so invoke the run loop.
+ base::RunLoop().RunUntilIdle();
+
+ ASSERT_EQ(2U, observer.observed_entries_count());
+ EXPECT_EQ(MakeStringPair("C", "G3"), observer.get_observed_entry(1));
+}
+
+} // namespace chrome_variations
« no previous file with comments | « chrome/common/variations/child_process_field_trial_syncer.cc ('k') | chrome/gpu/chrome_content_gpu_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698