Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5295)

Unified Diff: chrome/common/variations/child_process_field_trial_syncer.h

Issue 2034933002: Make field trials activated in the GPU process be reflected in browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: IWYU Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | chrome/common/variations/child_process_field_trial_syncer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/variations/child_process_field_trial_syncer.h
diff --git a/chrome/common/variations/child_process_field_trial_syncer.h b/chrome/common/variations/child_process_field_trial_syncer.h
index 404dcb3fd02fb0916639bc744f3a979081ed34c6..6a8a9eedde51bcbbeafee4eeccefa295e941c556 100644
--- a/chrome/common/variations/child_process_field_trial_syncer.h
+++ b/chrome/common/variations/child_process_field_trial_syncer.h
@@ -9,7 +9,6 @@
#include "base/macros.h"
#include "base/metrics/field_trial.h"
-#include "ipc/ipc_sender.h"
namespace base {
class CommandLine;
@@ -22,13 +21,14 @@ namespace chrome_variations {
// processes. Specifically, when a field trial is activated in the browser, it
// also activates it in the child process and when a field trial is activated
// in the child process, it notifies the browser process to activate it.
-class ChildProcessFieldTrialSyncer : public base::FieldTrialList::Observer {
+class ChildProcessFieldTrialSyncer {
public:
// ChildProcessFieldTrialSyncer constructor taking an externally owned
- // |ipc_sender| param for sending ChromeViewHostMsg_FieldTrialActivated IPCs
- // to the browser process. The |ipc_sender| must outlive this object.
- explicit ChildProcessFieldTrialSyncer(IPC::Sender* ipc_sender);
- ~ChildProcessFieldTrialSyncer() override;
+ // |observer| param that's responsible for sending IPCs to the browser process
+ // when a trial is activated. The |observer| must outlive this object.
+ explicit ChildProcessFieldTrialSyncer(
+ base::FieldTrialList::Observer* observer);
+ ~ChildProcessFieldTrialSyncer();
// Initializes field trial state change observation and notifies the browser
// of any field trials that might have already been activated.
@@ -40,11 +40,7 @@ class ChildProcessFieldTrialSyncer : public base::FieldTrialList::Observer {
const std::string& group_name);
private:
- // base::FieldTrialList::Observer:
- void OnFieldTrialGroupFinalized(const std::string& trial_name,
- const std::string& group_name) override;
-
- IPC::Sender* const ipc_sender_;
+ base::FieldTrialList::Observer* const observer_;
DISALLOW_COPY_AND_ASSIGN(ChildProcessFieldTrialSyncer);
};
« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | chrome/common/variations/child_process_field_trial_syncer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698