(Pre)Parser unification: use shorter type names.

(Pre)Parser unification: use shorter type names.

R=mstarzinger@chromium.org
BUG=

Committed: https://code.google.com/p/v8/source/detail?r=20044

[marja, 2014-03-18 16:01:05]

mstarzinger, ptal.

"typedef typename Traits::Type::Expression ExpressionT;" << beautiful, isn't it
:P

https://codereview.chromium.org/203493002/diff/1/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/203493002/diff/1/src/preparser.h#newcode85
src/preparser.h:85: typedef typename Traits::Type::Expression ExpressionT;
Had to use ExpressionT. If this is Expression everywhere when parser.cc uses
Expression, it resolves to this one and not v8::internal::Expression.

[Michael Starzinger, 2014-03-18 16:12:48]

LGTM.

https://codereview.chromium.org/203493002/diff/1/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/203493002/diff/1/src/preparser.h#newcode384
src/preparser.h:384: ExpressionT ParseRegExpLiteral(bool seen_equal,
nit: Several occurrences here (above and below) should fit into one line now.

[marja, 2014-03-18 16:17:39]

thx!

https://codereview.chromium.org/203493002/diff/1/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/203493002/diff/1/src/preparser.h#newcode384
src/preparser.h:384: ExpressionT ParseRegExpLiteral(bool seen_equal,
On 2014/03/18 16:12:48, Michael Starzinger wrote:
> nit: Several occurrences here (above and below) should fit into one line now.

Done.

[marja, 2014-03-18 17:05:52]

Committed patchset #2 manually as r20044 (presubmit successful).