Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2034903002: Consider start time for frame painting and fix naming in test. (Closed)

Created:
4 years, 6 months ago by DaleCurtis
Modified:
4 years, 6 months ago
Reviewers:
xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Consider start time for frame painting and fix naming in test. These changes were accidentally dropped from the final commit after approval in previous review: https://codereview.chromium.org/2007463005 BUG=614099 TBR=xhwang Committed: https://crrev.com/094201df5bbbc6ca093c3c0d6812da1202a53504 Cr-Commit-Position: refs/heads/master@{#397614}

Patch Set 1 #

Patch Set 2 : Update expectations for test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -24 lines) Patch
M media/renderers/video_renderer_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M media/renderers/video_renderer_impl_unittest.cc View 1 20 chunks +28 lines, -24 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
DaleCurtis
4 years, 6 months ago (2016-06-02 20:39:02 UTC) #2
xhwang
lgtm
4 years, 6 months ago (2016-06-02 20:39:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2034903002/1
4 years, 6 months ago (2016-06-02 20:40:16 UTC) #4
DaleCurtis
Whoops, looks like one of the tests added while that CL was in review needs ...
4 years, 6 months ago (2016-06-02 20:50:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034903002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2034903002/20001
4 years, 6 months ago (2016-06-02 20:51:21 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-03 03:18:59 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 03:21:03 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/094201df5bbbc6ca093c3c0d6812da1202a53504
Cr-Commit-Position: refs/heads/master@{#397614}

Powered by Google App Engine
This is Rietveld 408576698