Issue 2034893003: Fixed interactive ui test regression

Issue 2034893003: Fixed interactive ui test regression (Closed)

Created:
4 years, 6 months ago by kylix_rd

Modified:
4 years, 6 months ago

Reviewers:
Finnur, sky, bruthig

CC:
chromium-reviews, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Fixed interactive ui test regression BUG=617056 Committed: https://crrev.com/e02d1460890d367b121a1d17a1e655a9bc6bef37 Cr-Commit-Position: refs/heads/master@{#397822}

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -12 lines)			Patch
	M	chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc	View		1 chunk	+1 line, -8 lines	0 comments	Download
	M	ui/views/controls/button/custom_button.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Total messages: 13 (5 generated)

kylix_rd

Fixed test regression. Ink drop state mis-matches while dragging can cause a DCHECK failure. Fix ...

4 years, 6 months ago (2016-06-03 18:03:58 UTC) #3

kylix_rd

Since sky@ is an owner in chrome/browser/ui/views, should I still wait for an L.G.T.M. from ...

4 years, 6 months ago (2016-06-03 21:54:28 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034893003/1

4 years, 6 months ago (2016-06-03 22:22:23 UTC) #9

commit-bot: I haz the power

4 years, 6 months ago (2016-06-03 22:30:07 UTC) #13

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/e02d1460890d367b121a1d17a1e655a9bc6bef37
Cr-Commit-Position: refs/heads/master@{#397822}