⛵ Add time measurement for deferred handler.

Add time measurement for deferred handler.

BUG=614452
Committed: https://crrev.com/e34f32917ffc2f325b89fa9c7f56a05cb33f5195
Cr-Commit-Position: refs/heads/master@{#398024}

[Peter Wen, 2016-06-02 18:57:00]

wnwen@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Peter Wen, 2016-06-02 18:57:00]

Hi Alexei, I'd like to add this metric before I start chopping up
DeferredStartupHandler and getting it ready to be started earlier.

[Alexei Svitkine (slow), 2016-06-02 19:20:21]

lgtm

[Peter Wen, 2016-06-02 19:32:45]

wnwen@chromium.org changed reviewers:
+ tedchoc@chromium.org

[Peter Wen, 2016-06-02 19:32:46]

+tedchoc@ for DeferredStartupHandler OWNERS.

[Ted C, 2016-06-03 16:47:30]

lgtm

https://codereview.chromium.org/2034833002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java
(right):

https://codereview.chromium.org/2034833002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java:161:
"UMA.Debug.EnableCrashUpload.DeferredStartUpFinishedtime",
based on the name, I would have expected this to be:

SystemClock.uptimeMillis() - UmaUtils.getMainEntryPointTime()

To me, this would be more Duration than FinishedTime.  But the comment in
the histograms.xml is pretty clear, so I'm fine with whatever you prefer.

[Ted C, 2016-06-03 16:47:32]

lgtm

[Peter Wen, 2016-06-06 13:45:55]

Thanks for the quick reviews! :)

https://codereview.chromium.org/2034833002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java
(right):

https://codereview.chromium.org/2034833002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java:161:
"UMA.Debug.EnableCrashUpload.DeferredStartUpFinishedtime",
On 2016/06/03 16:47:30, Ted C wrote:
> based on the name, I would have expected this to be:
> 
> SystemClock.uptimeMillis() - UmaUtils.getMainEntryPointTime()
> 
> To me, this would be more Duration than FinishedTime.  But the comment in
> the histograms.xml is pretty clear, so I'm fine with whatever you prefer.

Renamed, makes a lot more sense and matches the comment now. :)

[Peter Wen, 2016-06-06 13:46:00]

The CQ bit was checked by wnwen@chromium.org

[Peter Wen, 2016-06-06 13:46:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/2034833002/#ps20001
(title: "Rename UMA stat.")

[commit-bot: I haz the power, 2016-06-06 13:46:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2034833002/20001

[commit-bot: I haz the power, 2016-06-06 14:58:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-06 14:59:56]

Description was changed from

==========
Add time measurement for deferred handler.

BUG=614452
==========

to

==========
Add time measurement for deferred handler.

BUG=614452

Committed: https://crrev.com/e34f32917ffc2f325b89fa9c7f56a05cb33f5195
Cr-Commit-Position: refs/heads/master@{#398024}
==========

[commit-bot: I haz the power, 2016-06-06 14:59:57]

Patchset 2 (id:??) landed as
https://crrev.com/e34f32917ffc2f325b89fa9c7f56a05cb33f5195
Cr-Commit-Position: refs/heads/master@{#398024}