LayoutTests/fast/block/float/split-inline-sibling-of-float-crash.html - Issue 203483002: Clear sibling floats while splitting inline flow.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/block/float/split-inline-sibling-of-float-crash.html

Issue 203483002: Clear sibling floats while splitting inline flow. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <html>

	2 <p style='white: fuchsia; padding: 198px 108 2147483647px; '></p>

	3 <myelement>

	4 <body>

	5 <sup style="kerning: 7; display: table-row; "></sup>

	6 <iframe align=right style="font-variant: small-caps;> mask: url(#tCF84); bor der-right-width: 20543.4114163cm; "></iframe>

	7 <p id=tCF100></p>

	8 <span id=tCF104>

	9 </body>

	10 <script>

	11 window.onload = function() {

	12 keygenElem = document.createElementNS("http://www.w3.org/1999/xhtml", "keyge n");

	13 keygenElem.setAttribute("autofocus", "Tm");

	14 document.body.appendChild(keygenElem);

	15 document.body.appendChild(document.createElementNS("http://www.w3.org/1999/x html", "td"));

	16 document.body.appendChild(document.createElementNS("http://www.w3.org/1999/x html", "video"));

	17 setTimeout("CFcrash()", 1);
	aarya 2014/03/18 17:45:44 Is this timeout really required ? can you try with Is this timeout really required ? can you try with offsettop to force layout ? that way we get rid of the notifydones and waituntildones :) kenrb 2014/03/18 18:00:21 I tried that, but the UAF no longer reproduced, an Show quoted text On 2014/03/18 17:45:44, aarya wrote: > Is this timeout really required ? can you try with offsettop to force layout ? > that way we get rid of the notifydones and waituntildones :) I tried that, but the UAF no longer reproduced, and I couldn't figure out why. The timeout value is irrelevant, but pulling the code into a single function and replacing setTimeout() with document.body.offsetTop for some reason broke the test case. In general the test was hard to simplify, I think mostly because you have to get the float overhangs right.
	18

	19 if (window.testRunner)

	20 testRunner.waitUntilDone();

	21 }

	22 function CFcrash() {

	23 tCF104.appendChild(tCF100);

	24 document.body.innerHTML = "PASS if no crash or assert under ASAN";

	25

	26 if (window.testRunner) {

	27 testRunner.dumpAsText();

	28 testRunner.notifyDone();

	29 }

	30 }

	31 </script>

	32 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/block/float/split-inline-sibling-of-float-crash-expected.txt » ('j') | no next file with comments »