Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2034813003: Make changing a record's type an atomic operation. (Closed)

Created:
4 years, 6 months ago by bcwhite
Modified:
4 years, 6 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make changing a record's type an atomic operation. Accessing the type_id is generally thread-safe within the PMA code because it is only accessed once the memory is owned to the exclusion of any other allocator. The same can't be said, however, once access to it is given to a caller and so protection needs to be added so that callers can't introduce race conditions due to their inter-process thread-unsafety. BUG=546019 Committed: https://crrev.com/84a8e0963774266d197d9bf90c952d983ab74869 Cr-Commit-Position: refs/heads/master@{#397711}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -18 lines) Patch
M base/metrics/persistent_histogram_allocator.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/metrics/persistent_memory_allocator.h View 1 chunk +4 lines, -2 lines 0 comments Download
M base/metrics/persistent_memory_allocator.cc View 7 chunks +18 lines, -11 lines 0 comments Download
M base/metrics/persistent_memory_allocator_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
bcwhite
4 years, 6 months ago (2016-06-03 14:58:48 UTC) #2
Alexei Svitkine (slow)
lgtm
4 years, 6 months ago (2016-06-03 15:07:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034813003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2034813003/1
4 years, 6 months ago (2016-06-03 15:15:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 15:19:47 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 15:21:48 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/84a8e0963774266d197d9bf90c952d983ab74869
Cr-Commit-Position: refs/heads/master@{#397711}

Powered by Google App Engine
This is Rietveld 408576698