Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2034773002: PPC/s390: [stubs] An easier way of defining a stub call interface descriptor. (Closed)

Created:
4 years, 6 months ago by JaideepBajwa
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [stubs] An easier way of defining a stub call interface descriptor. Port a2fef3af4b3ba5e973ce56dd454b8c77f00a4897 Original commit message: This CL introduces a DECLARE_DEFAULT_DESCRIPTOR macro that helps defining a CallInterfaceDescriptor in a cases where it is not important which registers to use for passing arguments. One can use such descriptors for new TurboFan stubs. HasPropertyDescriptor now uses the new machinery. R=ishell@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Committed: https://crrev.com/9bba1494f403d35ac7e53779eb7706c01d9124ea Cr-Commit-Position: refs/heads/master@{#36687}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/s390/interface-descriptors-s390.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
JaideepBajwa
PTAL
4 years, 6 months ago (2016-06-02 15:07:11 UTC) #1
john.yan
lgtm
4 years, 6 months ago (2016-06-02 15:08:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2034773002/1
4 years, 6 months ago (2016-06-02 15:10:55 UTC) #4
Igor Sheludko
lgtm. Thanks!
4 years, 6 months ago (2016-06-02 15:13:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 15:32:25 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 15:33:00 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9bba1494f403d35ac7e53779eb7706c01d9124ea
Cr-Commit-Position: refs/heads/master@{#36687}

Powered by Google App Engine
This is Rietveld 408576698