Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2034763002: Make multi-gpu tests independent of intermittent display changes on OSX (Closed)

Created:
4 years, 6 months ago by Julien Isorce Samsung
Modified:
4 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make multi-gpu tests independent of intermittent display changes on OSX For currently unknown reasons the display change callback is triggered with kCGDisplayAddFlag flag while running the gpu tests. Since it might change the active gpu at any time it can make the tests fail. For now let's make the tests reliable but further investigation on the callback will follow. BUG=616759 R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org Committed: https://crrev.com/f4b4acf1f2810b76dea587e7fb69e47556c948f4 Cr-Commit-Position: refs/heads/master@{#397487}

Patch Set 1 #

Patch Set 2 : Oups ofcourse negate the previous condition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M content/browser/gpu/gpu_data_manager_impl_private.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Julien Isorce Samsung
PTAL.
4 years, 6 months ago (2016-06-02 15:03:53 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2034763002/1
4 years, 6 months ago (2016-06-02 15:04:45 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/170053)
4 years, 6 months ago (2016-06-02 15:28:22 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034763002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2034763002/20001
4 years, 6 months ago (2016-06-02 16:32:34 UTC) #7
Zhenyao Mo
lgtm
4 years, 6 months ago (2016-06-02 16:47:18 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-02 17:38:09 UTC) #10
Ken Russell (switch to Gerrit)
lgtm
4 years, 6 months ago (2016-06-02 18:11:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034763002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2034763002/20001
4 years, 6 months ago (2016-06-02 19:15:50 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-02 19:21:57 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 19:24:09 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f4b4acf1f2810b76dea587e7fb69e47556c948f4
Cr-Commit-Position: refs/heads/master@{#397487}

Powered by Google App Engine
This is Rietveld 408576698