Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Side by Side Diff: Source/core/rendering/RenderTableCell.cpp

Issue 203473002: Should not render the table cell border if the <td> is empty. Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/fast/table/table-cell-border-no-doctype-expected.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 1201 matching lines...) Expand 10 before | Expand all | Expand 10 after
1212 return; 1212 return;
1213 1213
1214 LayoutRect paintRect = LayoutRect(paintOffset, pixelSnappedSize()); 1214 LayoutRect paintRect = LayoutRect(paintOffset, pixelSnappedSize());
1215 paintBoxShadow(paintInfo, paintRect, style(), Normal); 1215 paintBoxShadow(paintInfo, paintRect, style(), Normal);
1216 1216
1217 // Paint our cell background. 1217 // Paint our cell background.
1218 paintBackgroundsBehindCell(paintInfo, paintOffset, this); 1218 paintBackgroundsBehindCell(paintInfo, paintOffset, this);
1219 1219
1220 paintBoxShadow(paintInfo, paintRect, style(), Inset); 1220 paintBoxShadow(paintInfo, paintRect, style(), Inset);
1221 1221
1222 if (!style()->hasBorder() || tableElt->collapseBorders()) 1222 if (!style()->hasBorder() || tableElt->collapseBorders() || (!firstChild() & & document().inQuirksMode()))
1223 return; 1223 return;
1224 1224
1225 paintBorder(paintInfo, paintRect, style()); 1225 paintBorder(paintInfo, paintRect, style());
1226 } 1226 }
1227 1227
1228 void RenderTableCell::paintMask(PaintInfo& paintInfo, const LayoutPoint& paintOf fset) 1228 void RenderTableCell::paintMask(PaintInfo& paintInfo, const LayoutPoint& paintOf fset)
1229 { 1229 {
1230 if (style()->visibility() != VISIBLE || paintInfo.phase != PaintPhaseMask) 1230 if (style()->visibility() != VISIBLE || paintInfo.phase != PaintPhaseMask)
1231 return; 1231 return;
1232 1232
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
1275 1275
1276 RenderTableCell* RenderTableCell::createAnonymousWithParentRenderer(const Render Object* parent) 1276 RenderTableCell* RenderTableCell::createAnonymousWithParentRenderer(const Render Object* parent)
1277 { 1277 {
1278 RenderTableCell* newCell = RenderTableCell::createAnonymous(&parent->documen t()); 1278 RenderTableCell* newCell = RenderTableCell::createAnonymous(&parent->documen t());
1279 RefPtr<RenderStyle> newStyle = RenderStyle::createAnonymousStyleWithDisplay( parent->style(), TABLE_CELL); 1279 RefPtr<RenderStyle> newStyle = RenderStyle::createAnonymousStyleWithDisplay( parent->style(), TABLE_CELL);
1280 newCell->setStyle(newStyle.release()); 1280 newCell->setStyle(newStyle.release());
1281 return newCell; 1281 return newCell;
1282 } 1282 }
1283 1283
1284 } // namespace WebCore 1284 } // namespace WebCore
OLDNEW
« no previous file with comments | « LayoutTests/fast/table/table-cell-border-no-doctype-expected.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698