[gn] Port test262 archiving to gn

[gn] Port test262 archiving to gn

This calls the action that archives test262 in gn. In gn
we can't specify an action output outside the product
directory. This works around it with an extra action
stamp file in the product directory, while the archive
remains in the test directory.

We don't want to generate the archive in the product
directory, as some legacy archiving scripts might include
it and it's too large. It should only be included in the
swarming tasks that are going to use it for testing.

BUG=chromium:474921
Committed: https://crrev.com/0d65554c057512d39d04e443a79ba5c54697be9d
Cr-Commit-Position: refs/heads/master@{#36731}

[Michael Achenbach, 2016-06-06 08:26:39]

Description was changed from

==========
[gn] Port test262 archiving to gn

BUG=
==========

to

==========
[gn] Port test262 archiving to gn

BUG=chromium:474921
==========

[Michael Achenbach, 2016-06-06 08:26:43]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-06 08:26:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2034713005/20001

[Michael Achenbach, 2016-06-06 08:31:03]

Description was changed from

==========
[gn] Port test262 archiving to gn

BUG=chromium:474921
==========

to

==========
[gn] Port test262 archiving to gn

This calls the action that archives test262 in gn. In gn
we can't specify an action output outside the product
directory. This works around it with an extra action
stamp file in the product directory, while the archive
remains in the test directory.

We don't want to generate the archive in the product
directory, as some legacy archiving scripts might include
it and it's to large. It should only be included in the
swarming tasks that are going to use it for testing.

BUG=chromium:474921
==========

[Michael Achenbach, 2016-06-06 08:31:03]

machenbach@chromium.org changed reviewers:
+ jochen@chromium.org, vogelheim@chromium.org

[Michael Achenbach, 2016-06-06 08:32:10]

PTAL

https://codereview.chromium.org/2034713005/diff/20001/test/test262/BUILD.gn
File test/test262/BUILD.gn (right):

https://codereview.chromium.org/2034713005/diff/20001/test/test262/BUILD.gn#n...
test/test262/BUILD.gn:7: if (v8_test_isolation_mode != "noop") {
This ports:
https://cs.chromium.org/chromium/src/v8/test/test262/test262.gyp?l=22

[vogelheim, 2016-06-06 08:48:26]

lgtm

https://codereview.chromium.org/2034713005/diff/20001/test/test262/archive.py
File test/test262/archive.py (right):

https://codereview.chromium.org/2034713005/diff/20001/test/test262/archive.py...
test/test262/archive.py:31: # Workaround for GN. We can't specify the tarfile as
output because it's
Can we get around this workaround once the gyp deprecation is complete?

[Michael Achenbach, 2016-06-06 08:51:21]

https://codereview.chromium.org/2034713005/diff/20001/test/test262/archive.py
File test/test262/archive.py (right):

https://codereview.chromium.org/2034713005/diff/20001/test/test262/archive.py...
test/test262/archive.py:31: # Workaround for GN. We can't specify the tarfile as
output because it's
On 2016/06/06 08:48:26, vogelheim wrote:
> Can we get around this workaround once the gyp deprecation is complete?

Not because of the deprecation. Only by investing more work and e.g.
blacklisting the archive in all infrastructure archiving scripts out there (I
count three). I'll keep that in mind with a lower prio.

[Michael Achenbach, 2016-06-06 08:52:10]

Description was changed from

==========
[gn] Port test262 archiving to gn

This calls the action that archives test262 in gn. In gn
we can't specify an action output outside the product
directory. This works around it with an extra action
stamp file in the product directory, while the archive
remains in the test directory.

We don't want to generate the archive in the product
directory, as some legacy archiving scripts might include
it and it's to large. It should only be included in the
swarming tasks that are going to use it for testing.

BUG=chromium:474921
==========

to

==========
[gn] Port test262 archiving to gn

This calls the action that archives test262 in gn. In gn
we can't specify an action output outside the product
directory. This works around it with an extra action
stamp file in the product directory, while the archive
remains in the test directory.

We don't want to generate the archive in the product
directory, as some legacy archiving scripts might include
it and it's too large. It should only be included in the
swarming tasks that are going to use it for testing.

BUG=chromium:474921
==========

[Michael Achenbach, 2016-06-06 08:52:20]

The CQ bit was unchecked by machenbach@chromium.org

[Michael Achenbach, 2016-06-06 08:52:23]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2016-06-06 08:52:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2034713005/20001

[commit-bot: I haz the power, 2016-06-06 08:55:22]

Description was changed from

==========
[gn] Port test262 archiving to gn

This calls the action that archives test262 in gn. In gn
we can't specify an action output outside the product
directory. This works around it with an extra action
stamp file in the product directory, while the archive
remains in the test directory.

We don't want to generate the archive in the product
directory, as some legacy archiving scripts might include
it and it's too large. It should only be included in the
swarming tasks that are going to use it for testing.

BUG=chromium:474921
==========

to

==========
[gn] Port test262 archiving to gn

This calls the action that archives test262 in gn. In gn
we can't specify an action output outside the product
directory. This works around it with an extra action
stamp file in the product directory, while the archive
remains in the test directory.

We don't want to generate the archive in the product
directory, as some legacy archiving scripts might include
it and it's too large. It should only be included in the
swarming tasks that are going to use it for testing.

BUG=chromium:474921
==========

[commit-bot: I haz the power, 2016-06-06 08:55:22]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-06 08:57:05]

Description was changed from

==========
[gn] Port test262 archiving to gn

This calls the action that archives test262 in gn. In gn
we can't specify an action output outside the product
directory. This works around it with an extra action
stamp file in the product directory, while the archive
remains in the test directory.

We don't want to generate the archive in the product
directory, as some legacy archiving scripts might include
it and it's too large. It should only be included in the
swarming tasks that are going to use it for testing.

BUG=chromium:474921
==========

to

==========
[gn] Port test262 archiving to gn

This calls the action that archives test262 in gn. In gn
we can't specify an action output outside the product
directory. This works around it with an extra action
stamp file in the product directory, while the archive
remains in the test directory.

We don't want to generate the archive in the product
directory, as some legacy archiving scripts might include
it and it's too large. It should only be included in the
swarming tasks that are going to use it for testing.

BUG=chromium:474921

Committed: https://crrev.com/0d65554c057512d39d04e443a79ba5c54697be9d
Cr-Commit-Position: refs/heads/master@{#36731}
==========

[commit-bot: I haz the power, 2016-06-06 08:57:06]

Patchset 2 (id:??) landed as
https://crrev.com/0d65554c057512d39d04e443a79ba5c54697be9d
Cr-Commit-Position: refs/heads/master@{#36731}