improve completions in closures and switch statements

improve completions in closures and switch statements

This addresses several situations where the parser interprets "as" as
part of an "as" expression, but the user is trying to enter the "async"
keyword or an identifier starting with "as".

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/2d310f1e6700dfc59db0e14d6648fde738ea5a7d

[danrubel, 2016-06-03 01:56:12]

danrubel@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2016-06-03 13:48:54]

lgtm

https://codereview.chromium.org/2034713004/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/services/completion/dart/keyword_contributor.dart
(right):

https://codereview.chromium.org/2034713004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart/keyword_contributor.dart:85:
_addSuggestion2(SYNC_STAR, relevance: DART_RELEVANCE_HIGH);
This one seems strange, but I'll trust your judgement.

[danrubel, 2016-06-06 12:09:46]

Description was changed from

==========
improve completions in closures and switch statements

This addresses several situations where the parser interprets "as" as
part of an "as" expression, but the user is trying to enter the "async"
keyword or an identifier starting with "as".
==========

to

==========
improve completions in closures and switch statements

This addresses several situations where the parser interprets "as" as
part of an "as" expression, but the user is trying to enter the "async"
keyword or an identifier starting with "as".

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/2d310f1e6700dfc59db0e14d6648fde738ea5a7d
==========

[danrubel, 2016-06-06 12:09:47]

Committed patchset #2 (id:20001) manually as
2d310f1e6700dfc59db0e14d6648fde738ea5a7d (presubmit successful).