content/browser/fileapi/file_system_url_request_job_unittest.cc - Issue 2034663003: Remove use of deprecated MessageLoop methods in content.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/fileapi/file_system_url_request_job_unittest.cc

Issue 2034663003: Remove use of deprecated MessageLoop methods in content. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/fileapi/file_system_dir_url_request_job_unittest.cc ('k') | content/browser/frame_host/render_widget_host_view_child_frame.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/fileapi/file_system_url_request_job_unittest.cc

diff --git a/content/browser/fileapi/file_system_url_request_job_unittest.cc b/content/browser/fileapi/file_system_url_request_job_unittest.cc

index 98d21c5157736a13be25a88e9e104856d52801fa..0b4fa751bf3e6737c21bd6073c63e428bd6eb820 100644

--- a/content/browser/fileapi/file_system_url_request_job_unittest.cc

+++ b/content/browser/fileapi/file_system_url_request_job_unittest.cc

@@ -17,6 +17,7 @@

#include "base/memory/weak_ptr.h"

#include "base/rand_util.h"

#include "base/run_loop.h"

+#include "base/single_thread_task_runner.h"

#include "base/strings/string_piece.h"

#include "base/strings/stringprintf.h"

#include "base/strings/utf_string_conversions.h"

@@ -391,7 +392,8 @@ TEST_F(FileSystemURLRequestJobTest, Cancel) {

TestRequestNoRun(CreateFileSystemURL("file1.dat"));

// Run StartAsync() and only StartAsync().

- base::MessageLoop::current()->DeleteSoon(FROM_HERE, request_.release());

+ base::ThreadTaskRunnerHandle::Get()->DeleteSoon(FROM_HERE,

+ request_.release());

base::RunLoop().RunUntilIdle();

// If we get here, success! we didn't crash!

}