Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1179)

Unified Diff: content/browser/service_worker/service_worker_browsertest.cc

Issue 2034663002: ServiceWorker: Keep the worker alive until FetchEvent.waitUntil settles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_browsertest.cc
diff --git a/content/browser/service_worker/service_worker_browsertest.cc b/content/browser/service_worker/service_worker_browsertest.cc
index 60c6b2bad01ea5e7e20668f906df300a31826a29..76d0d3b77568d1791484e3f50242c8c405d85fb1 100644
--- a/content/browser/service_worker/service_worker_browsertest.cc
+++ b/content/browser/service_worker/service_worker_browsertest.cc
@@ -651,9 +651,12 @@ class ServiceWorkerVersionBrowserTest : public ServiceWorkerBrowserTest {
int request_id =
version_->StartRequest(ServiceWorkerMetrics::EventType::INSTALL,
CreateReceiver(BrowserThread::UI, done, result));
- version_->DispatchEvent<ServiceWorkerHostMsg_InstallEventFinished>(
- request_id, ServiceWorkerMsg_InstallEvent(request_id),
- base::Bind(&self::ReceiveInstallEventOnIOThread, this, done, result));
+ version_
+ ->RegisterRequestCallback<ServiceWorkerHostMsg_InstallEventFinished>(
+ request_id, base::Bind(&self::ReceiveInstallEventOnIOThread, this,
+ done, result));
+ version_->DispatchEvent({request_id},
+ ServiceWorkerMsg_InstallEvent(request_id));
}
void ReceiveInstallEventOnIOThread(const base::Closure& done,

Powered by Google App Engine
This is Rietveld 408576698