content/browser/service_worker/embedded_worker_test_helper.h - Issue 2034663002: ServiceWorker: Keep the worker alive until FetchEvent.waitUntil settles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/embedded_worker_test_helper.h

Issue 2034663002: ServiceWorker: Keep the worker alive until FetchEvent.waitUntil settles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/browser/service_worker/embedded_worker_test_helper.cc » ('j') | content/browser/service_worker/service_worker_metrics.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/embedded_worker_test_helper.h

diff --git a/content/browser/service_worker/embedded_worker_test_helper.h b/content/browser/service_worker/embedded_worker_test_helper.h

index ba45120cb4808458d37b480e29c6fbc9e19c1d9c..3eea699383850487631da369cacee1cd2865c17d 100644

--- a/content/browser/service_worker/embedded_worker_test_helper.h

+++ b/content/browser/service_worker/embedded_worker_test_helper.h

@@ -126,7 +126,8 @@ class EmbeddedWorkerTestHelper : public IPC::Sender,

virtual void OnExtendableMessageEvent(int embedded_worker_id, int request_id);

virtual void OnInstallEvent(int embedded_worker_id, int request_id);

virtual void OnFetchEvent(int embedded_worker_id,

- int request_id,

+ int response_request_id,

+ int finish_request_id,

const ServiceWorkerFetchRequest& request);

virtual void OnPushEvent(int embedded_worker_id,

int request_id,

@@ -159,7 +160,8 @@ class EmbeddedWorkerTestHelper : public IPC::Sender,

int request_id,

const ServiceWorkerMsg_ExtendableMessageEvent_Params& params);

void OnInstallEventStub(int request_id);

- void OnFetchEventStub(int request_id,

+ void OnFetchEventStub(int response_request_id,

+ int event_request_id,

falken 2016/06/09 19:28:48 There is some inconsistency throughout this patch

shimazu 2016/06/10 10:26:49 Done.

const ServiceWorkerFetchRequest& request);

void OnPushEventStub(int request_id, const PushEventPayload& payload);

void OnSetupMojoStub(int thread_id,

« no previous file with comments | « no previous file | content/browser/service_worker/embedded_worker_test_helper.cc » ('j') | content/browser/service_worker/service_worker_metrics.h » ('J')