Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(936)

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ForeignFetchEvent.cpp

Issue 2034663002: ServiceWorker: Keep the worker alive until FetchEvent.waitUntil settles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/serviceworkers/ForeignFetchEvent.cpp
diff --git a/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchEvent.cpp b/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchEvent.cpp
index fb4a559db0e2e8196af9965e7f22f82b996e22be..483be1f7c8f7bcee5b55e066d4032bf54e9f515d 100644
--- a/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchEvent.cpp
+++ b/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchEvent.cpp
@@ -11,7 +11,6 @@
#include "wtf/RefPtr.h"
namespace blink {
-
ForeignFetchEvent* ForeignFetchEvent::create()
{
return new ForeignFetchEvent();
@@ -19,12 +18,12 @@ ForeignFetchEvent* ForeignFetchEvent::create()
ForeignFetchEvent* ForeignFetchEvent::create(ScriptState* scriptState, const AtomicString& type, const ForeignFetchEventInit& initializer)
{
- return new ForeignFetchEvent(scriptState, type, initializer, nullptr);
+ return new ForeignFetchEvent(scriptState, type, initializer, nullptr, nullptr);
}
-ForeignFetchEvent* ForeignFetchEvent::create(ScriptState* scriptState, const AtomicString& type, const ForeignFetchEventInit& initializer, ForeignFetchRespondWithObserver* observer)
+ForeignFetchEvent* ForeignFetchEvent::create(ScriptState* scriptState, const AtomicString& type, const ForeignFetchEventInit& initializer, ForeignFetchRespondWithObserver* respondWithObserver, WaitUntilObserver* waitUntilObserver)
{
- return new ForeignFetchEvent(scriptState, type, initializer, observer);
+ return new ForeignFetchEvent(scriptState, type, initializer, respondWithObserver, waitUntilObserver);
}
Request* ForeignFetchEvent::request() const
@@ -53,9 +52,9 @@ ForeignFetchEvent::ForeignFetchEvent()
{
}
-ForeignFetchEvent::ForeignFetchEvent(ScriptState* scriptState, const AtomicString& type, const ForeignFetchEventInit& initializer, ForeignFetchRespondWithObserver* observer)
- : ExtendableEvent(type, initializer)
- , m_observer(observer)
+ForeignFetchEvent::ForeignFetchEvent(ScriptState* scriptState, const AtomicString& type, const ForeignFetchEventInit& initializer, ForeignFetchRespondWithObserver* respondWithObserver, WaitUntilObserver* waitUntilObserver)
+ : ExtendableEvent(type, initializer, waitUntilObserver)
+ , m_observer(respondWithObserver)
{
if (initializer.hasOrigin())
m_origin = initializer.origin();

Powered by Google App Engine
This is Rietveld 408576698