content/renderer/service_worker/service_worker_context_client.h - Issue 2034663002: ServiceWorker: Keep the worker alive until FetchEvent.waitUntil settles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/service_worker/service_worker_context_client.h

Issue 2034663002: ServiceWorker: Keep the worker alive until FetchEvent.waitUntil settles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/service_worker/service_worker_messages.h ('k') | content/renderer/service_worker/service_worker_context_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/service_worker/service_worker_context_client.h

diff --git a/content/renderer/service_worker/service_worker_context_client.h b/content/renderer/service_worker/service_worker_context_client.h

index deaf7b05c49f7be7e8b2fcaf74ba5e82fe05d0df..0cbb9df722ebf50ab4405c6e0d832950169a207a 100644

--- a/content/renderer/service_worker/service_worker_context_client.h

+++ b/content/renderer/service_worker/service_worker_context_client.h

@@ -137,10 +137,12 @@ class ServiceWorkerContextClient

void didHandleInstallEvent(

int request_id,

blink::WebServiceWorkerEventResult result) override;

- void didHandleFetchEvent(int request_id) override;

- void didHandleFetchEvent(

- int request_id,

+ void respondToFetchEvent(int response_id) override;

+ void respondToFetchEvent(

+ int response_id,

const blink::WebServiceWorkerResponse& response) override;

+ void didHandleFetchEvent(int event_finish_id,

+ blink::WebServiceWorkerEventResult result) override;

void didHandleNotificationClickEvent(

int request_id,

blink::WebServiceWorkerEventResult result) override;

@@ -200,7 +202,9 @@ class ServiceWorkerContextClient

int request_id,

const ServiceWorkerMsg_ExtendableMessageEvent_Params& params);

void OnInstallEvent(int request_id);

- void OnFetchEvent(int request_id, const ServiceWorkerFetchRequest& request);

+ void OnFetchEvent(int response_id,

+ int event_finish_id,

+ const ServiceWorkerFetchRequest& request);

void OnNotificationClickEvent(

int request_id,

int64_t persistent_notification_id,