Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: content/browser/service_worker/embedded_worker_test_helper.cc

Issue 2034663002: ServiceWorker: Keep the worker alive until FetchEvent.waitUntil settles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/embedded_worker_test_helper.cc
diff --git a/content/browser/service_worker/embedded_worker_test_helper.cc b/content/browser/service_worker/embedded_worker_test_helper.cc
index 68d26f874abad9d5ae6c1426f5bb981d483e3747..2c00f3a8ec920cebd3cac6ca0a2045c405f3fc43 100644
--- a/content/browser/service_worker/embedded_worker_test_helper.cc
+++ b/content/browser/service_worker/embedded_worker_test_helper.cc
@@ -237,10 +237,11 @@ void EmbeddedWorkerTestHelper::OnInstallEvent(int embedded_worker_id,
void EmbeddedWorkerTestHelper::OnFetchEvent(
int embedded_worker_id,
- int request_id,
+ int response_id,
+ int event_finish_id,
const ServiceWorkerFetchRequest& request) {
- SimulateSend(new ServiceWorkerHostMsg_FetchEventFinished(
- embedded_worker_id, request_id,
+ SimulateSend(new ServiceWorkerHostMsg_FetchEventResponse(
+ embedded_worker_id, response_id,
SERVICE_WORKER_FETCH_EVENT_RESULT_RESPONSE,
ServiceWorkerResponse(
GURL(), 200, "OK", blink::WebServiceWorkerResponseTypeDefault,
@@ -249,6 +250,9 @@ void EmbeddedWorkerTestHelper::OnFetchEvent(
false /* is_in_cache_storage */,
std::string() /* cache_storage_cache_name */,
ServiceWorkerHeaderList() /* cors_exposed_header_names */)));
+ SimulateSend(new ServiceWorkerHostMsg_FetchEventFinished(
+ embedded_worker_id, event_finish_id,
+ blink::WebServiceWorkerEventResultCompleted));
}
void EmbeddedWorkerTestHelper::OnPushEvent(int embedded_worker_id,
@@ -394,12 +398,14 @@ void EmbeddedWorkerTestHelper::OnInstallEventStub(int request_id) {
}
void EmbeddedWorkerTestHelper::OnFetchEventStub(
- int request_id,
+ int response_id,
+ int event_finish_id,
const ServiceWorkerFetchRequest& request) {
base::ThreadTaskRunnerHandle::Get()->PostTask(
- FROM_HERE, base::Bind(&EmbeddedWorkerTestHelper::OnFetchEvent,
- weak_factory_.GetWeakPtr(),
- current_embedded_worker_id_, request_id, request));
+ FROM_HERE,
+ base::Bind(&EmbeddedWorkerTestHelper::OnFetchEvent,
+ weak_factory_.GetWeakPtr(), current_embedded_worker_id_,
+ response_id, event_finish_id, request));
}
void EmbeddedWorkerTestHelper::OnPushEventStub(

Powered by Google App Engine
This is Rietveld 408576698