third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h - Issue 2034663002: ServiceWorker: Keep the worker alive until FetchEvent.waitUntil settles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h

Issue 2034663002: ServiceWorker: Keep the worker alive until FetchEvent.waitUntil settles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Separate DispathEvent into two part Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/service_worker/service_worker_context_client.h ('K') | « third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp ('k') | third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp » ('j') | third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h

diff --git a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h

index bddf8ab959bda0fd893bd39a22beaca335608c66..a79a1c7287f32385cbbdc91038e7988aaa83af4e 100644

--- a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h

+++ b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h

@@ -74,8 +74,8 @@ public:

void dispatchActivateEvent(int) override;

void dispatchExtendableMessageEvent(int eventID, const WebString& message, const WebSecurityOrigin& sourceOrigin, const WebMessagePortChannelArray&, const WebServiceWorkerClientInfo&) override;

void dispatchExtendableMessageEvent(int eventID, const WebString& message, const WebSecurityOrigin& sourceOrigin, const WebMessagePortChannelArray&, std::unique_ptr<WebServiceWorker::Handle>) override;

- void dispatchFetchEvent(int, const WebServiceWorkerRequest&) override;

- void dispatchForeignFetchEvent(int, const WebServiceWorkerRequest&) override;

+ void dispatchFetchEvent(int, int, const WebServiceWorkerRequest&) override;

+ void dispatchForeignFetchEvent(int, int, const WebServiceWorkerRequest&) override;

falken 2016/06/06 10:01:40 we need variable names for these ints now that it'

shimazu 2016/06/09 05:44:21 Done.

void dispatchInstallEvent(int) override;

void dispatchNotificationClickEvent(int, int64_t notificationID, const WebNotificationData&, int actionIndex) override;

void dispatchNotificationCloseEvent(int, int64_t notificationID, const WebNotificationData&) override;