Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: content/browser/service_worker/service_worker_fetch_dispatcher.cc

Issue 2034663002: ServiceWorker: Keep the worker alive until FetchEvent.waitUntil settles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add an inline comment Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_fetch_dispatcher.cc
diff --git a/content/browser/service_worker/service_worker_fetch_dispatcher.cc b/content/browser/service_worker/service_worker_fetch_dispatcher.cc
index 2b9ecc9205f9a9a698661ab679ff2e564dea24b6..e2f6dae40e055907087d994e9137775492d4adbc 100644
--- a/content/browser/service_worker/service_worker_fetch_dispatcher.cc
+++ b/content/browser/service_worker/service_worker_fetch_dispatcher.cc
@@ -11,6 +11,7 @@
#include "content/browser/service_worker/embedded_worker_status.h"
#include "content/browser/service_worker/service_worker_version.h"
#include "content/common/service_worker/service_worker_messages.h"
+#include "content/common/service_worker/service_worker_utils.h"
namespace content {
@@ -32,6 +33,13 @@ EventType ResourceTypeToEventType(ResourceType resource_type) {
return EventType::FETCH_SUB_RESOURCE;
}
}
+
+ServiceWorkerMetrics::EventType FetchTypeToWaitUntilEventType(
+ ServiceWorkerFetchType type) {
+ if (type == ServiceWorkerFetchType::FOREIGN_FETCH)
+ return ServiceWorkerMetrics::EventType::FOREIGN_FETCH_WAITUNTIL;
+ return ServiceWorkerMetrics::EventType::FETCH_WAITUNTIL;
+}
} // namespace
ServiceWorkerFetchDispatcher::ServiceWorkerFetchDispatcher(
@@ -95,13 +103,21 @@ void ServiceWorkerFetchDispatcher::DispatchFetchEvent() {
base::Closure prepare_callback = prepare_callback_;
prepare_callback.Run();
- int request_id = version_->StartRequest(
+ int response_id = version_->StartRequest(
GetEventType(), base::Bind(&ServiceWorkerFetchDispatcher::DidFail,
weak_factory_.GetWeakPtr()));
- version_->DispatchEvent<ServiceWorkerHostMsg_FetchEventFinished>(
- request_id, ServiceWorkerMsg_FetchEvent(request_id, *request_.get()),
- base::Bind(&ServiceWorkerFetchDispatcher::DidFinish,
- weak_factory_.GetWeakPtr()));
+ int event_finish_id = version_->StartRequest(
+ FetchTypeToWaitUntilEventType(request_->fetch_type),
+ base::Bind(&ServiceWorkerUtils::NoOpStatusCallback));
+
+ version_->RegisterRequestCallback<ServiceWorkerHostMsg_FetchEventResponse>(
+ response_id, base::Bind(&ServiceWorkerFetchDispatcher::DidFinish,
+ weak_factory_.GetWeakPtr()));
+ version_->RegisterSimpleRequest<ServiceWorkerHostMsg_FetchEventFinished>(
+ event_finish_id);
+ version_->DispatchEvent({response_id, event_finish_id},
+ ServiceWorkerMsg_FetchEvent(
+ response_id, event_finish_id, *request_.get()));
}
void ServiceWorkerFetchDispatcher::DidPrepare() {

Powered by Google App Engine
This is Rietveld 408576698