content/browser/service_worker/service_worker_browsertest.cc - Issue 2034663002: ServiceWorker: Keep the worker alive until FetchEvent.waitUntil settles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_browsertest.cc

Issue 2034663002: ServiceWorker: Keep the worker alive until FetchEvent.waitUntil settles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add an inline comment Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/embedded_worker_test_helper.cc ('k') | content/browser/service_worker/service_worker_fetch_dispatcher.cc » ('j') | content/browser/service_worker/service_worker_metrics.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_browsertest.cc

diff --git a/content/browser/service_worker/service_worker_browsertest.cc b/content/browser/service_worker/service_worker_browsertest.cc

index fae510d160824629013c23a96dad89b770795cdc..a062f40b21b38a523c950fb68ace0afbd532e866 100644

--- a/content/browser/service_worker/service_worker_browsertest.cc

+++ b/content/browser/service_worker/service_worker_browsertest.cc

@@ -653,9 +653,12 @@ class ServiceWorkerVersionBrowserTest : public ServiceWorkerBrowserTest {

int request_id =

version_->StartRequest(ServiceWorkerMetrics::EventType::INSTALL,

CreateReceiver(BrowserThread::UI, done, result));

- version_->DispatchEvent<ServiceWorkerHostMsg_InstallEventFinished>(

- request_id, ServiceWorkerMsg_InstallEvent(request_id),

- base::Bind(&self::ReceiveInstallEventOnIOThread, this, done, result));

+ version_

+ ->RegisterRequestCallback<ServiceWorkerHostMsg_InstallEventFinished>(

+ request_id, base::Bind(&self::ReceiveInstallEventOnIOThread, this,

+ done, result));

+ version_->DispatchEvent({request_id},

+ ServiceWorkerMsg_InstallEvent(request_id));

}

void ReceiveInstallEventOnIOThread(const base::Closure& done,