third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h - Issue 2034663002: ServiceWorker: Keep the worker alive until FetchEvent.waitUntil settles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h

Issue 2034663002: ServiceWorker: Keep the worker alive until FetchEvent.waitUntil settles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp ('K') | « third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h

diff --git a/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h b/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h

index 1e1dc4fa436f892714a482b114f35e659f8ec5cd..5a44993b5a13ffad355b3ac80b22953376e1ed6a 100644

--- a/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h

+++ b/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h

@@ -56,8 +56,8 @@ public:

virtual void dispatchExtendableMessageEvent(int eventID, const WebString& message, const WebSecurityOrigin& sourceOrigin, const WebMessagePortChannelArray&, const WebServiceWorkerClientInfo&) = 0;

virtual void dispatchExtendableMessageEvent(int eventID, const WebString& message, const WebSecurityOrigin& sourceOrigin, const WebMessagePortChannelArray&, std::unique_ptr<WebServiceWorker::Handle>) = 0;

virtual void dispatchInstallEvent(int eventID) = 0;

- virtual void dispatchFetchEvent(int eventID, const WebServiceWorkerRequest& webRequest) = 0;

- virtual void dispatchForeignFetchEvent(int eventID, const WebServiceWorkerRequest& webRequest) = 0;

+ virtual void dispatchFetchEvent(int responseEventID, int finishEventID, const WebServiceWorkerRequest& webRequest) = 0;

+ virtual void dispatchForeignFetchEvent(int responseEventID, int finishEventID, const WebServiceWorkerRequest& webRequest) = 0;

falken 2016/06/16 06:23:11 responseID and eventFinishID for consistency with

shimazu 2016/06/21 02:43:38 Done.

virtual void dispatchNotificationClickEvent(int eventID, int64_t notificationID, const WebNotificationData&, int actionIndex) = 0;

virtual void dispatchNotificationCloseEvent(int eventID, int64_t notificationID, const WebNotificationData&) = 0;

virtual void dispatchPushEvent(int eventID, const WebString& data) = 0;