third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h - Issue 2034663002: ServiceWorker: Keep the worker alive until FetchEvent.waitUntil settles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h

Issue 2034663002: ServiceWorker: Keep the worker alive until FetchEvent.waitUntil settles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h ('K') | « third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp ('k') | third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp » ('j') | third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h

diff --git a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h

index 52d6d4a73b574cb9dcc9aac00f3e86afb6011310..91e242ef001409c4a8230cd70fc9142e1d285f9f 100644

--- a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h

+++ b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h

@@ -58,8 +58,9 @@ public:

void didHandleActivateEvent(int eventID, WebServiceWorkerEventResult) override;

void didHandleExtendableMessageEvent(int eventID, WebServiceWorkerEventResult) override;

- void didHandleFetchEvent(int fetchEventID) override;

- void didHandleFetchEvent(int fetchEventID, const WebServiceWorkerResponse&) override;

+ void respondToFetchEvent(int responseID) override;

+ void respondToFetchEvent(int responseID, const WebServiceWorkerResponse&) override;

+ void didHandleFetchEvent(int eventFinishID, WebServiceWorkerEventResult) override;

void didHandleInstallEvent(int installEventID, WebServiceWorkerEventResult) override;

void didHandleNotificationClickEvent(int eventID, WebServiceWorkerEventResult) override;

void didHandleNotificationCloseEvent(int eventID, WebServiceWorkerEventResult) override;