Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ForeignFetchEvent.cpp

Issue 2034663002: ServiceWorker: Keep the worker alive until FetchEvent.waitUntil settles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/serviceworkers/ForeignFetchEvent.cpp
diff --git a/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchEvent.cpp b/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchEvent.cpp
index 2843673ae53bcc4f9441c0d2e4efba4814b5abf6..64caca45e98034f83892df0cfa736fca17e1d82e 100644
--- a/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchEvent.cpp
+++ b/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchEvent.cpp
@@ -17,12 +17,12 @@ ForeignFetchEvent* ForeignFetchEvent::create()
ForeignFetchEvent* ForeignFetchEvent::create(const AtomicString& type, const ForeignFetchEventInit& initializer)
{
- return new ForeignFetchEvent(type, initializer, nullptr);
+ return new ForeignFetchEvent(type, initializer, nullptr, nullptr);
}
-ForeignFetchEvent* ForeignFetchEvent::create(const AtomicString& type, const ForeignFetchEventInit& initializer, ForeignFetchRespondWithObserver* observer)
+ForeignFetchEvent* ForeignFetchEvent::create(const AtomicString& type, const ForeignFetchEventInit& initializer, ForeignFetchRespondWithObserver* respondWithObserver, WaitUntilObserver* waitUntilObserver)
{
- return new ForeignFetchEvent(type, initializer, observer);
+ return new ForeignFetchEvent(type, initializer, respondWithObserver, waitUntilObserver);
}
Request* ForeignFetchEvent::request() const
@@ -51,9 +51,9 @@ ForeignFetchEvent::ForeignFetchEvent()
{
}
-ForeignFetchEvent::ForeignFetchEvent(const AtomicString& type, const ForeignFetchEventInit& initializer, ForeignFetchRespondWithObserver* observer)
- : ExtendableEvent(type, initializer)
- , m_observer(observer)
+ForeignFetchEvent::ForeignFetchEvent(const AtomicString& type, const ForeignFetchEventInit& initializer, ForeignFetchRespondWithObserver* respondWithObserver, WaitUntilObserver* waitUntilObserver)
+ : ExtendableEvent(type, initializer, waitUntilObserver)
+ , m_observer(respondWithObserver)
{
if (initializer.hasRequest())
m_request = initializer.request();

Powered by Google App Engine
This is Rietveld 408576698