Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Side by Side Diff: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

Issue 2034663002: ServiceWorker: Keep the worker alive until FetchEvent.waitUntil settles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 String origin; 124 String origin;
125 if (!sourceOrigin.isUnique()) 125 if (!sourceOrigin.isUnique())
126 origin = sourceOrigin.toString(); 126 origin = sourceOrigin.toString();
127 ServiceWorker* source = ServiceWorker::from(m_workerGlobalScope->getExecutio nContext(), wrapUnique(handle.release())); 127 ServiceWorker* source = ServiceWorker::from(m_workerGlobalScope->getExecutio nContext(), wrapUnique(handle.release()));
128 WaitUntilObserver* observer = WaitUntilObserver::create(workerGlobalScope(), WaitUntilObserver::Message, eventID); 128 WaitUntilObserver* observer = WaitUntilObserver::create(workerGlobalScope(), WaitUntilObserver::Message, eventID);
129 129
130 Event* event = ExtendableMessageEvent::create(value, origin, ports, source, observer); 130 Event* event = ExtendableMessageEvent::create(value, origin, ports, source, observer);
131 workerGlobalScope()->dispatchExtendableEvent(event, observer); 131 workerGlobalScope()->dispatchExtendableEvent(event, observer);
132 } 132 }
133 133
134 void ServiceWorkerGlobalScopeProxy::dispatchFetchEvent(int eventID, const WebSer viceWorkerRequest& webRequest) 134 void ServiceWorkerGlobalScopeProxy::dispatchFetchEvent(int responseID, int event FinishID, const WebServiceWorkerRequest& webRequest)
135 { 135 {
136 RespondWithObserver* observer = RespondWithObserver::create(workerGlobalScop e(), eventID, webRequest.url(), webRequest.mode(), webRequest.frameType(), webRe quest.requestContext()); 136 WaitUntilObserver* waitUntilObserver = WaitUntilObserver::create(workerGloba lScope(), WaitUntilObserver::Fetch, eventFinishID);
137 RespondWithObserver* respondWithObserver = RespondWithObserver::create(worke rGlobalScope(), responseID, webRequest.url(), webRequest.mode(), webRequest.fram eType(), webRequest.requestContext(), waitUntilObserver);
137 Request* request = Request::create(workerGlobalScope()->scriptController()-> getScriptState(), webRequest); 138 Request* request = Request::create(workerGlobalScope()->scriptController()-> getScriptState(), webRequest);
138 request->getHeaders()->setGuard(Headers::ImmutableGuard); 139 request->getHeaders()->setGuard(Headers::ImmutableGuard);
139 FetchEventInit eventInit; 140 FetchEventInit eventInit;
140 eventInit.setCancelable(true); 141 eventInit.setCancelable(true);
141 eventInit.setRequest(request); 142 eventInit.setRequest(request);
142 eventInit.setClientId(webRequest.isMainResourceLoad() ? WebString() : webReq uest.clientId()); 143 eventInit.setClientId(webRequest.isMainResourceLoad() ? WebString() : webReq uest.clientId());
143 eventInit.setIsReload(webRequest.isReload()); 144 eventInit.setIsReload(webRequest.isReload());
144 FetchEvent* fetchEvent = FetchEvent::create(workerGlobalScope()->scriptContr oller()->getScriptState(), EventTypeNames::fetch, eventInit, observer); 145 FetchEvent* fetchEvent = FetchEvent::create(workerGlobalScope()->scriptContr oller()->getScriptState(), EventTypeNames::fetch, eventInit, respondWithObserver , waitUntilObserver);
146 waitUntilObserver->willDispatchEvent();
145 DispatchEventResult dispatchResult = workerGlobalScope()->dispatchEvent(fetc hEvent); 147 DispatchEventResult dispatchResult = workerGlobalScope()->dispatchEvent(fetc hEvent);
146 observer->didDispatchEvent(dispatchResult); 148 respondWithObserver->didDispatchEvent(dispatchResult);
149 // false is okay because waitUntil for fetch event doesn't care about the
150 // promise rejection or an uncaught runtime script error.
151 waitUntilObserver->didDispatchEvent(false /* errorOccurred */);
147 } 152 }
148 153
149 void ServiceWorkerGlobalScopeProxy::dispatchForeignFetchEvent(int eventID, const WebServiceWorkerRequest& webRequest) 154 void ServiceWorkerGlobalScopeProxy::dispatchForeignFetchEvent(int responseID, in t eventFinishID, const WebServiceWorkerRequest& webRequest)
150 { 155 {
151 RefPtr<SecurityOrigin> origin = SecurityOrigin::create(webRequest.referrerUr l()); 156 RefPtr<SecurityOrigin> origin = SecurityOrigin::create(webRequest.referrerUr l());
152 ForeignFetchRespondWithObserver* observer = ForeignFetchRespondWithObserver: :create(workerGlobalScope(), eventID, webRequest.url(), webRequest.mode(), webRe quest.frameType(), webRequest.requestContext(), origin); 157 WaitUntilObserver* waitUntilObserver = WaitUntilObserver::create(workerGloba lScope(), WaitUntilObserver::Fetch, eventFinishID);
158 ForeignFetchRespondWithObserver* respondWithObserver = ForeignFetchRespondWi thObserver::create(workerGlobalScope(), responseID, webRequest.url(), webRequest .mode(), webRequest.frameType(), webRequest.requestContext(), origin, waitUntilO bserver);
153 Request* request = Request::create(workerGlobalScope()->scriptController()-> getScriptState(), webRequest); 159 Request* request = Request::create(workerGlobalScope()->scriptController()-> getScriptState(), webRequest);
154 request->getHeaders()->setGuard(Headers::ImmutableGuard); 160 request->getHeaders()->setGuard(Headers::ImmutableGuard);
155 ForeignFetchEventInit eventInit; 161 ForeignFetchEventInit eventInit;
156 eventInit.setCancelable(true); 162 eventInit.setCancelable(true);
157 eventInit.setRequest(request); 163 eventInit.setRequest(request);
158 eventInit.setOrigin(origin->toString()); 164 eventInit.setOrigin(origin->toString());
159 ForeignFetchEvent* fetchEvent = ForeignFetchEvent::create(workerGlobalScope( )->scriptController()->getScriptState(), EventTypeNames::foreignfetch, eventInit , observer); 165 ForeignFetchEvent* fetchEvent = ForeignFetchEvent::create(workerGlobalScope( )->scriptController()->getScriptState(), EventTypeNames::foreignfetch, eventInit , respondWithObserver, waitUntilObserver);
166 waitUntilObserver->willDispatchEvent();
160 DispatchEventResult dispatchResult = workerGlobalScope()->dispatchEvent(fetc hEvent); 167 DispatchEventResult dispatchResult = workerGlobalScope()->dispatchEvent(fetc hEvent);
161 observer->didDispatchEvent(dispatchResult); 168 respondWithObserver->didDispatchEvent(dispatchResult);
169 // false is okay because waitUntil for foreign fetch event doesn't care
170 // about the promise rejection or an uncaught runtime script error.
171 waitUntilObserver->didDispatchEvent(false /* errorOccurred */);
162 } 172 }
163 173
164 void ServiceWorkerGlobalScopeProxy::dispatchInstallEvent(int eventID) 174 void ServiceWorkerGlobalScopeProxy::dispatchInstallEvent(int eventID)
165 { 175 {
166 WaitUntilObserver* observer = WaitUntilObserver::create(workerGlobalScope(), WaitUntilObserver::Install, eventID); 176 WaitUntilObserver* observer = WaitUntilObserver::create(workerGlobalScope(), WaitUntilObserver::Install, eventID);
167 Event* event; 177 Event* event;
168 if (RuntimeEnabledFeatures::foreignFetchEnabled()) 178 if (RuntimeEnabledFeatures::foreignFetchEnabled())
169 event = InstallEvent::create(EventTypeNames::install, ExtendableEventIni t(), observer); 179 event = InstallEvent::create(EventTypeNames::install, ExtendableEventIni t(), observer);
170 else 180 else
171 event = ExtendableEvent::create(EventTypeNames::install, ExtendableEvent Init(), observer); 181 event = ExtendableEvent::create(EventTypeNames::install, ExtendableEvent Init(), observer);
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
298 return *m_document; 308 return *m_document;
299 } 309 }
300 310
301 ServiceWorkerGlobalScope* ServiceWorkerGlobalScopeProxy::workerGlobalScope() con st 311 ServiceWorkerGlobalScope* ServiceWorkerGlobalScopeProxy::workerGlobalScope() con st
302 { 312 {
303 DCHECK(m_workerGlobalScope); 313 DCHECK(m_workerGlobalScope);
304 return m_workerGlobalScope; 314 return m_workerGlobalScope;
305 } 315 }
306 316
307 } // namespace blink 317 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698