Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Side by Side Diff: content/browser/service_worker/service_worker_fetch_dispatcher.cc

Issue 2034663002: ServiceWorker: Keep the worker alive until FetchEvent.waitUntil settles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/service_worker/service_worker_fetch_dispatcher.h" 5 #include "content/browser/service_worker/service_worker_fetch_dispatcher.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/trace_event/trace_event.h" 10 #include "base/trace_event/trace_event.h"
11 #include "content/browser/service_worker/embedded_worker_status.h" 11 #include "content/browser/service_worker/embedded_worker_status.h"
12 #include "content/browser/service_worker/service_worker_version.h" 12 #include "content/browser/service_worker/service_worker_version.h"
13 #include "content/common/service_worker/service_worker_messages.h" 13 #include "content/common/service_worker/service_worker_messages.h"
14 #include "content/common/service_worker/service_worker_utils.h"
14 15
15 namespace content { 16 namespace content {
16 17
17 namespace { 18 namespace {
18 using EventType = ServiceWorkerMetrics::EventType; 19 using EventType = ServiceWorkerMetrics::EventType;
19 EventType ResourceTypeToEventType(ResourceType resource_type) { 20 EventType ResourceTypeToEventType(ResourceType resource_type) {
20 switch (resource_type) { 21 switch (resource_type) {
21 case RESOURCE_TYPE_MAIN_FRAME: 22 case RESOURCE_TYPE_MAIN_FRAME:
22 return EventType::FETCH_MAIN_FRAME; 23 return EventType::FETCH_MAIN_FRAME;
23 case RESOURCE_TYPE_SUB_FRAME: 24 case RESOURCE_TYPE_SUB_FRAME:
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 } 89 }
89 90
90 void ServiceWorkerFetchDispatcher::DispatchFetchEvent() { 91 void ServiceWorkerFetchDispatcher::DispatchFetchEvent() {
91 DCHECK_EQ(EmbeddedWorkerStatus::RUNNING, version_->running_status()) 92 DCHECK_EQ(EmbeddedWorkerStatus::RUNNING, version_->running_status())
92 << "Worker stopped too soon after it was started."; 93 << "Worker stopped too soon after it was started.";
93 94
94 DCHECK(!prepare_callback_.is_null()); 95 DCHECK(!prepare_callback_.is_null());
95 base::Closure prepare_callback = prepare_callback_; 96 base::Closure prepare_callback = prepare_callback_;
96 prepare_callback.Run(); 97 prepare_callback.Run();
97 98
98 int request_id = version_->StartRequest( 99 int response_id = version_->StartRequest(
99 GetEventType(), base::Bind(&ServiceWorkerFetchDispatcher::DidFail, 100 GetEventType(), base::Bind(&ServiceWorkerFetchDispatcher::DidFail,
100 weak_factory_.GetWeakPtr())); 101 weak_factory_.GetWeakPtr()));
101 version_->DispatchEvent<ServiceWorkerHostMsg_FetchEventFinished>( 102 int event_finish_id = version_->StartRequest(
102 request_id, ServiceWorkerMsg_FetchEvent(request_id, *request_.get()), 103 ServiceWorkerMetrics::EventType::FETCH_WAITUNTIL,
103 base::Bind(&ServiceWorkerFetchDispatcher::DidFinish, 104 base::Bind(&ServiceWorkerUtils::NoOpStatusCallback));
104 weak_factory_.GetWeakPtr())); 105
106 version_->RegisterRequestCallback<ServiceWorkerHostMsg_FetchEventResponse>(
107 response_id, base::Bind(&ServiceWorkerFetchDispatcher::DidFinish,
108 weak_factory_.GetWeakPtr()));
109 version_->RegisterSimpleRequest<ServiceWorkerHostMsg_FetchEventFinished>(
110 event_finish_id);
111 version_->DispatchEvent({response_id, event_finish_id},
112 ServiceWorkerMsg_FetchEvent(
113 response_id, event_finish_id, *request_.get()));
105 } 114 }
106 115
107 void ServiceWorkerFetchDispatcher::DidPrepare() { 116 void ServiceWorkerFetchDispatcher::DidPrepare() {
108 DCHECK(!prepare_callback_.is_null()); 117 DCHECK(!prepare_callback_.is_null());
109 base::Closure prepare_callback = prepare_callback_; 118 base::Closure prepare_callback = prepare_callback_;
110 prepare_callback.Run(); 119 prepare_callback.Run();
111 } 120 }
112 121
113 void ServiceWorkerFetchDispatcher::DidFail(ServiceWorkerStatusCode status) { 122 void ServiceWorkerFetchDispatcher::DidFail(ServiceWorkerStatusCode status) {
114 DCHECK(!fetch_callback_.is_null()); 123 DCHECK(!fetch_callback_.is_null());
(...skipping 19 matching lines...) Expand all
134 } 143 }
135 144
136 ServiceWorkerMetrics::EventType ServiceWorkerFetchDispatcher::GetEventType() 145 ServiceWorkerMetrics::EventType ServiceWorkerFetchDispatcher::GetEventType()
137 const { 146 const {
138 if (request_->fetch_type == ServiceWorkerFetchType::FOREIGN_FETCH) 147 if (request_->fetch_type == ServiceWorkerFetchType::FOREIGN_FETCH)
139 return ServiceWorkerMetrics::EventType::FOREIGN_FETCH; 148 return ServiceWorkerMetrics::EventType::FOREIGN_FETCH;
140 return ResourceTypeToEventType(resource_type_); 149 return ResourceTypeToEventType(resource_type_);
141 } 150 }
142 151
143 } // namespace content 152 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698