ServiceWorker: Keep the worker alive until FetchEvent.waitUntil settles

content/browser/service_worker/service_worker_fetch_dispatcher.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/service_worker/service_worker_fetch_dispatcher.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/trace_event/trace_event.h"
 #include "content/browser/service_worker/service_worker_version.h"
 #include "content/common/service_worker/service_worker_messages.h"
+#include "content/common/service_worker/service_worker_utils.h"
 
 namespace content {
 
 namespace {
 using EventType = ServiceWorkerMetrics::EventType;
 EventType ResourceTypeToEventType(ResourceType resource_type) {
   switch (resource_type) {
     case RESOURCE_TYPE_MAIN_FRAME:
       return EventType::FETCH_MAIN_FRAME;
     case RESOURCE_TYPE_SUB_FRAME:
@@ skipping 64 matching lines @@
 }
 
 void ServiceWorkerFetchDispatcher::DispatchFetchEvent() {
   DCHECK_EQ(ServiceWorkerVersion::RUNNING, version_->running_status())
       << "Worker stopped too soon after it was started.";
 
   DCHECK(!prepare_callback_.is_null());
   base::Closure prepare_callback = prepare_callback_;
   prepare_callback.Run();
 
-  int request_id = version_->StartRequest(
+  int response_id = version_->StartRequest(
       GetEventType(), base::Bind(&ServiceWorkerFetchDispatcher::DidFail,
                                  weak_factory_.GetWeakPtr()));
-  version_->DispatchEvent<ServiceWorkerHostMsg_FetchEventFinished>(
-      request_id, ServiceWorkerMsg_FetchEvent(request_id, *request_.get()),
-      base::Bind(&ServiceWorkerFetchDispatcher::DidFinish,
-                 weak_factory_.GetWeakPtr()));
+  int event_finish_id = version_->StartRequest(
+      ServiceWorkerMetrics::EventType::FETCH_WAITUNTIL,

[Marijn Kruisselbrink, 2016/06/15 12:37:07]

There should probably be separate FETCH_WAITUNTIL and FOREIGNFETCH_WAITUNTIL
event types? Or maybe combining them in stats doesn't matter, but then the
histogram description probably should be updated to mention both fetch and
foreign fetch.

[shimazu, 2016/06/21 02:43:37]

Done.

+      base::Bind(&ServiceWorkerUtils::NoOpStatusCallback));
+
+  version_->RegisterRequestCallback<ServiceWorkerHostMsg_FetchEventResponse>(
+      response_id, base::Bind(&ServiceWorkerFetchDispatcher::DidFinish,
+                              weak_factory_.GetWeakPtr()));
+  version_->RegisterSimpleRequest<ServiceWorkerHostMsg_FetchEventFinished>(
+      event_finish_id);
+  version_->DispatchEvent({response_id, event_finish_id},
+                          ServiceWorkerMsg_FetchEvent(
+                              response_id, event_finish_id, *request_.get()));
 }
 
 void ServiceWorkerFetchDispatcher::DidPrepare() {
   DCHECK(!prepare_callback_.is_null());
   base::Closure prepare_callback = prepare_callback_;
   prepare_callback.Run();
 }
 
 void ServiceWorkerFetchDispatcher::DidFail(ServiceWorkerStatusCode status) {
   DCHECK(!fetch_callback_.is_null());
@@ skipping 19 matching lines @@
 }
 
 ServiceWorkerMetrics::EventType ServiceWorkerFetchDispatcher::GetEventType()
     const {
   if (request_->fetch_type == ServiceWorkerFetchType::FOREIGN_FETCH)
     return ServiceWorkerMetrics::EventType::FOREIGN_FETCH;
   return ResourceTypeToEventType(resource_type_);
 }
 
 }  // namespace content