Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2034653002: Fix bug in yield* desugaring. (Closed)

Created:
4 years, 6 months ago by neis
Modified:
4 years, 6 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix bug in yield* desugaring. In one corner case, we incorrectly returned a value without first wrapping it in an iterator result object. R=littledan@chromium.org BUG=v8:5057 Committed: https://crrev.com/8154d977e4650bec931b27d52f62ba056d0d74c8 Cr-Commit-Position: refs/heads/master@{#36676}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -7 lines) Patch
M src/parsing/parser.cc View 3 chunks +16 lines, -7 lines 0 comments Download
M test/mjsunit/harmony/iterator-close.js View 1 chunk +72 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
neis
4 years, 6 months ago (2016-06-02 09:08:37 UTC) #1
Dan Ehrenberg
lgtm
4 years, 6 months ago (2016-06-02 09:14:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2034653002/1
4 years, 6 months ago (2016-06-02 09:16:53 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 09:42:41 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 09:44:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8154d977e4650bec931b27d52f62ba056d0d74c8
Cr-Commit-Position: refs/heads/master@{#36676}

Powered by Google App Engine
This is Rietveld 408576698