Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1061)

Issue 2034643002: Remove has_valgrind.py - the bots now set this flag explicitly (Closed)

Created:
4 years, 6 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 6 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com, Michael Achenbach
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove has_valgrind.py - the bots now set this flag explicitly BUG=none R=machenbach@chromium.org NOTRY=true Committed: https://crrev.com/a8f57df4f4e298f271ac5b544d7c2d69f01002dd Cr-Commit-Position: refs/heads/master@{#36673}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -22 lines) Patch
D gypfiles/has_valgrind.py View 1 chunk +0 lines, -21 lines 0 comments Download
M gypfiles/standalone.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
jochen (gone - plz use gerrit)
4 years, 6 months ago (2016-06-02 08:53:32 UTC) #1
Michael Achenbach
lgtm - can notry this. the bot does't run on cq anyway
4 years, 6 months ago (2016-06-02 08:58:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2034643002/1
4 years, 6 months ago (2016-06-02 08:58:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 09:01:34 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 09:03:03 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a8f57df4f4e298f271ac5b544d7c2d69f01002dd
Cr-Commit-Position: refs/heads/master@{#36673}

Powered by Google App Engine
This is Rietveld 408576698