Issue 203463014: Refactor VS toolchain code in gyp_chromium

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 203463014: Refactor VS toolchain code in gyp_chromium (Closed)

Created:
6 years, 9 months ago by scottmg

Modified:
6 years, 9 months ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Refactor VS toolchain code in gyp_chromium Pull out some code from gyp_chromium for less clutter, and easier to share with GN build files this way. R=brettw@chromium.org BUG=297677 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258119

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+146 lines, -120 lines)			Patch
	M	build/gyp_chromium	View		4 chunks	+5 lines, -120 lines	0 comments	Download
	A	build/vs_toolchain.py	View	1 2	1 chunk	+141 lines, -0 lines	0 comments	Download

Total messages: 7 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/203463014/1

6 years, 9 months ago (2014-03-19 19:48:11 UTC) #4

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 9 months ago (2014-03-19 19:51:49 UTC) #5

commit-bot: I haz the power

Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg

6 years, 9 months ago (2014-03-19 19:51:50 UTC) #6

scottmg

6 years, 9 months ago (2014-03-19 22:01:48 UTC) #7

Message was sent while issue was closed.

Committed patchset #3 manually as r258119 (presubmit successful).