Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 203463013: MIPS: Pretenure call new support. (Closed)

Created:
6 years, 9 months ago by kilvadyb
Modified:
6 years, 9 months ago
CC:
v8-dev
Base URL:
https://github.com/v8/v8.git@gbl
Visibility:
Public.

Description

MIPS: Pretenure call new support. Port r20076 (b7b1372) Original commit message: When FLAG_pretenure_call_new is on, we emit mementos on new object creation in full code, and consume the feedback in crankshaft. A key difference in the generated code for stubs is the allocation of an additional type vector slot for the CallNew AST node, which simplifies the CallConstructStub and CallFunctionStub considerably. Some performance tuning still needs to be addressed, therefore the flag is off at this moment, though fully functional. The goal is to remove the flag as soon as possible, which allows much code deletion (yay). BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -56 lines) Patch
M src/mips/builtins-mips.cc View 8 chunks +86 lines, -12 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 3 chunks +56 lines, -44 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kilvadyb
6 years, 9 months ago (2014-03-19 17:54:50 UTC) #1
Paul Lind
lgtm
6 years, 9 months ago (2014-03-19 19:57:59 UTC) #2
Paul Lind
6 years, 9 months ago (2014-03-19 20:01:31 UTC) #3
Committed as r20091.

Powered by Google App Engine
This is Rietveld 408576698