build/git-hooks/pre-commit - Issue 203463010: Remove "bashism" from plain shell script

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/git-hooks/pre-commit

Issue 203463010: Remove "bashism" from plain shell script (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/git-hooks/pre-commit

diff --git a/build/git-hooks/pre-commit b/build/git-hooks/pre-commit

index 1153649842c3fc765765b18a93c397ba5b5012d7..a39be2202cef12427192d6ac174fe3dec4d7f52d 100755

--- a/build/git-hooks/pre-commit

+++ b/build/git-hooks/pre-commit

@@ -23,8 +23,8 @@ EOF

exit 1

-if [[ -n "$(git ls-files .gitmodules)" &&

- -n "$(git diff-index --cached HEAD .gitmodules)" ]]; then

+if [ -n "$(git ls-files .gitmodules)" ] &&

+ [ -n "$(git diff-index --cached HEAD .gitmodules)" ]; then

cat <<EOF 1>&2

You are trying to commit a change to .gitmodules. That is not allowed.

To make changes to submodule names/paths, edit DEPS.

« no previous file with comments | « no previous file | no next file » | no next file with comments »