Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 203463004: Update to git-1.9.0. (Closed)

Created:
6 years, 9 months ago by szager1
Modified:
6 years, 9 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Update to git-1.9.0. Also, allow multiple git installations to exist side-by-side. This makes it easier to revert back to an old version quickly. BUG= R=maruel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258058

Patch Set 1 #

Patch Set 2 : Don't "force" win_tools.bat #

Patch Set 3 : tweaks #

Total comments: 7

Patch Set 4 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -37 lines) Patch
M bootstrap/win/win_tools.bat View 1 2 3 4 chunks +31 lines, -31 lines 0 comments Download
M update_depot_tools View 1 1 chunk +1 line, -1 line 0 comments Download
M update_depot_tools.bat View 1 2 3 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
szager1
6 years, 9 months ago (2014-03-18 21:56:49 UTC) #1
M-A Ruel
lgtm
6 years, 9 months ago (2014-03-19 00:52:40 UTC) #2
mmoss
https://codereview.chromium.org/203463004/diff/40001/bootstrap/win/win_tools.bat File bootstrap/win/win_tools.bat (right): https://codereview.chromium.org/203463004/diff/40001/bootstrap/win/win_tools.bat#newcode67 bootstrap/win/win_tools.bat:67: if "%DEPOT_TOOLS_GIT_190%" == "0" goto :GIT_1852_CHECK I don't remember, ...
6 years, 9 months ago (2014-03-19 05:11:15 UTC) #3
szager1
https://codereview.chromium.org/203463004/diff/40001/bootstrap/win/win_tools.bat File bootstrap/win/win_tools.bat (right): https://codereview.chromium.org/203463004/diff/40001/bootstrap/win/win_tools.bat#newcode67 bootstrap/win/win_tools.bat:67: if "%DEPOT_TOOLS_GIT_190%" == "0" goto :GIT_1852_CHECK On 2014/03/19 05:11:15, ...
6 years, 9 months ago (2014-03-19 05:41:57 UTC) #4
mmoss
https://codereview.chromium.org/203463004/diff/40001/bootstrap/win/win_tools.bat File bootstrap/win/win_tools.bat (right): https://codereview.chromium.org/203463004/diff/40001/bootstrap/win/win_tools.bat#newcode67 bootstrap/win/win_tools.bat:67: if "%DEPOT_TOOLS_GIT_190%" == "0" goto :GIT_1852_CHECK On 2014/03/19 05:41:57, ...
6 years, 9 months ago (2014-03-19 14:17:11 UTC) #5
szager1
Committed patchset #4 manually as r258058 (presubmit successful).
6 years, 9 months ago (2014-03-19 19:22:10 UTC) #6
szager1
6 years, 9 months ago (2014-03-19 19:22:41 UTC) #7
Message was sent while issue was closed.
On 2014/03/19 14:17:11, mmoss wrote:
>
https://codereview.chromium.org/203463004/diff/40001/bootstrap/win/win_tools.bat
> File bootstrap/win/win_tools.bat (right):
> 
>
https://codereview.chromium.org/203463004/diff/40001/bootstrap/win/win_tools....
> bootstrap/win/win_tools.bat:67: if "%DEPOT_TOOLS_GIT_190%" == "0" goto
> :GIT_1852_CHECK
> On 2014/03/19 05:41:57, szager1 wrote:
> > On 2014/03/19 05:11:15, mmoss wrote:
> > > I don't remember, do win vars == "0" if they are unset? If not, maybe this
> > > should be != "1".
> > 
> > I tested this; it only evaluates true if the var is set to a literal "0".
> 
> OK, I guess I just misunderstood the intent. I thought you were saying "if 190
> isn't set, try 1852; if 1852 isn't set, try 180", but it's really "use 190
> unless it's explicitly disabled, then use 1852, unless 1852 is explicitly
> disabled, then use 180". I guess that's OK, but as more versions are
supported,
> it gets more tedious to enable an older version, because you have to
explicitly
> disable all the more recent ones (and by implication, be aware they've been
> added and what the proper invocation is for disabling them).
> 
> Maybe the most recent one can always be "use unless disabled" but all the
older
> ones can be "don't use unless enabled", with a fallthrough to "oops, you
forgot
> to enable at least one version of git".

That sounds like a good follow-up change :)

Powered by Google App Engine
This is Rietveld 408576698