Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: ui/base/ime/linux/text_edit_command_auralinux.h

Issue 2034623002: Unify ui::TextEditCommand and ui::TextEditCommandAuraLinux::CommandId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor7_correct_text_edit_command_aura_typo
Patch Set: Rebase. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/base/ime/linux/text_edit_command_auralinux.h
diff --git a/ui/base/ime/linux/text_edit_command_auralinux.h b/ui/base/ime/linux/text_edit_command_auralinux.h
index 12dd7a1ac4e1d3c0a89901029064849007f17c49..92ff115afe3b74aa0d8550254933a16cfa6c2e88 100644
--- a/ui/base/ime/linux/text_edit_command_auralinux.h
+++ b/ui/base/ime/linux/text_edit_command_auralinux.h
@@ -11,70 +11,26 @@
namespace ui {
+enum class TextEditCommand;
+
// Represents a command that performs a specific operation on text.
// Copy and assignment are explicitly allowed; these objects live in vectors.
class UI_BASE_IME_EXPORT TextEditCommandAuraLinux {
public:
- enum CommandId {
- COPY,
- CUT,
- DELETE_BACKWARD,
- DELETE_FORWARD,
- DELETE_TO_BEGINNING_OF_LINE,
- DELETE_TO_BEGINNING_OF_PARAGRAPH,
- DELETE_TO_END_OF_LINE,
- DELETE_TO_END_OF_PARAGRAPH,
- DELETE_WORD_BACKWARD,
- DELETE_WORD_FORWARD,
- INSERT_TEXT,
- MOVE_BACKWARD,
- MOVE_DOWN,
- MOVE_FORWARD,
- MOVE_LEFT,
- MOVE_PAGE_DOWN,
- MOVE_PAGE_UP,
- MOVE_RIGHT,
- MOVE_TO_BEGINNING_OF_DOCUMENT,
- MOVE_TO_BEGINNING_OF_LINE,
- MOVE_TO_BEGINNING_OF_PARAGRAPH,
- MOVE_TO_END_OF_DOCUMENT,
- MOVE_TO_END_OF_LINE,
- MOVE_TO_END_OF_PARAGRAPH,
- MOVE_UP,
- MOVE_WORD_BACKWARD,
- MOVE_WORD_FORWARD,
- MOVE_WORD_LEFT,
- MOVE_WORD_RIGHT,
- PASTE,
- SELECT_ALL,
- SET_MARK,
- UNSELECT,
- INVALID_COMMAND
- };
-
- TextEditCommandAuraLinux(CommandId command_id,
- const std::string& argument,
- bool extend_selection)
- : command_id_(command_id),
- argument_(argument),
- extend_selection_(extend_selection) {}
+ TextEditCommandAuraLinux(TextEditCommand command, const std::string& argument)
+ : command_(command), argument_(argument) {}
- CommandId command_id() const { return command_id_; }
+ TextEditCommand command() const { return command_; }
const std::string& argument() const { return argument_; }
- bool extend_selection() const { return extend_selection_; }
// We communicate these commands back to blink with a string representation.
- // This will combine the base command name with "AndModifySelection" if we
- // have |extend_selection_| set.
std::string GetCommandString() const;
private:
- CommandId command_id_;
+ TextEditCommand command_;
+ // The text for TextEditCommand::INSERT_TEXT; otherwise empty and unused.
std::string argument_;
-
- // In addition to executing the command, modify the selection.
- bool extend_selection_;
};
} // namespace ui
« no previous file with comments | « chrome/browser/ui/libgtk2ui/gtk2_key_bindings_handler.cc ('k') | ui/base/ime/linux/text_edit_command_auralinux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698