chrome/browser/ui/libgtk2ui/gtk2_key_bindings_handler.h - Issue 2034623002: Unify ui::TextEditCommand and ui::TextEditCommandAuraLinux::CommandId.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/libgtk2ui/gtk2_key_bindings_handler.h

Issue 2034623002: Unify ui::TextEditCommand and ui::TextEditCommandAuraLinux::CommandId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor7_correct_text_edit_command_aura_typo

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/libgtk2ui/gtk2_key_bindings_handler.h

diff --git a/chrome/browser/ui/libgtk2ui/gtk2_key_bindings_handler.h b/chrome/browser/ui/libgtk2ui/gtk2_key_bindings_handler.h

index 32584d4e334edf824494514b17fb42dedb383b96..4c024e4ffc1d9bd5da2394f5fd1556cdae0a188f 100644

--- a/chrome/browser/ui/libgtk2ui/gtk2_key_bindings_handler.h

+++ b/chrome/browser/ui/libgtk2ui/gtk2_key_bindings_handler.h

@@ -70,9 +70,8 @@ class Gtk2KeyBindingsHandler {

GtkWidget* CreateNewHandler();

// Adds an edit command to the key event.

- void EditCommandMatched(ui::TextEditCommandAuraLinux::CommandId id,

- const std::string& value,

- bool extend_selection);

+ void EditCommandMatched(ui::TextEditCommand command,

+ const std::string& value);

// Builds a fake GdkEventKey from an XEvent.

void BuildGdkEventKeyFromXEvent(const base::NativeEvent& xevent,

« no previous file with comments | « no previous file | chrome/browser/ui/libgtk2ui/gtk2_key_bindings_handler.cc » ('j') | chrome/browser/ui/libgtk2ui/gtk2_key_bindings_handler.cc » ('J')