Chromium Code Reviews Chromium Code Reviews
Issue 2034623002:
Unify ui::TextEditCommand and ui::TextEditCommandAuraLinux::CommandId. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@refactor7_correct_text_edit_command_aura_typo| OLD | NEW |
|---|---|
| 1 // Copyright 2016 The Chromium Authors. All rights reserved. | 1 // Copyright 2016 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #ifndef UI_BASE_IME_TEXT_EDIT_COMMANDS_H_ | 5 #ifndef UI_BASE_IME_TEXT_EDIT_COMMANDS_H_ |
| 6 #define UI_BASE_IME_TEXT_EDIT_COMMANDS_H_ | 6 #define UI_BASE_IME_TEXT_EDIT_COMMANDS_H_ |
| 7 | 7 |
| 8 namespace ui { | 8 namespace ui { |
| 9 | 9 |
| 10 // Text editing commands for use by ui::TextInputClient. | 10 // Text editing commands for use by ui::TextInputClient. |
| 11 enum class TextEditCommand { | 11 enum class TextEditCommand { |
| 12 INVALID_COMMAND, | 12 DELETE_BACKWARD, |
| 13 DELETE_FORWARD, | |
| 14 DELETE_TO_BEGINNING_OF_LINE, | |
| 15 DELETE_TO_BEGINNING_OF_PARAGRAPH, | |
| 16 DELETE_TO_END_OF_LINE, | |
| 17 DELETE_TO_END_OF_PARAGRAPH, | |
| 18 DELETE_WORD_BACKWARD, | |
| 19 DELETE_WORD_FORWARD, | |
| 20 MOVE_BACKWARD, | |
| 21 MOVE_BACKWARD_AND_MODIFY_SELECTION, | |
| 22 MOVE_DOWN, | |
| 23 MOVE_DOWN_AND_MODIFY_SELECTION, | |
| 24 MOVE_FORWARD, | |
| 25 MOVE_FORWARD_AND_MODIFY_SELECTION, | |
| 26 MOVE_LEFT, | |
| 27 MOVE_LEFT_AND_MODIFY_SELECTION, | |
| 28 MOVE_PAGE_DOWN, | |
| 29 MOVE_PAGE_DOWN_AND_MODIFY_SELECTION, | |
| 30 MOVE_PAGE_UP, | |
| 31 MOVE_PAGE_UP_AND_MODIFY_SELECTION, | |
| 32 MOVE_RIGHT, | |
| 33 MOVE_RIGHT_AND_MODIFY_SELECTION, | |
| 34 MOVE_TO_BEGINNING_OF_DOCUMENT, | |
| 35 MOVE_TO_BEGINNING_OF_DOCUMENT_AND_MODIFY_SELECTION, | |
| 36 MOVE_TO_BEGINNING_OF_LINE, | |
| 37 MOVE_TO_BEGINNING_OF_LINE_AND_MODIFY_SELECTION, | |
| 38 MOVE_TO_BEGINNING_OF_PARAGRAPH, | |
| 39 MOVE_TO_BEGINNING_OF_PARAGRAPH_AND_MODIFY_SELECTION, | |
| 40 MOVE_TO_END_OF_DOCUMENT, | |
| 41 MOVE_TO_END_OF_DOCUMENT_AND_MODIFY_SELECTION, | |
| 42 MOVE_TO_END_OF_LINE, | |
| 43 MOVE_TO_END_OF_LINE_AND_MODIFY_SELECTION, | |
| 44 MOVE_TO_END_OF_PARAGRAPH, | |
| 45 MOVE_TO_END_OF_PARAGRAPH_AND_MODIFY_SELECTION, | |
| 46 MOVE_UP, | |
| 47 MOVE_UP_AND_MODIFY_SELECTION, | |
| 48 MOVE_WORD_BACKWARD, | |
| 49 MOVE_WORD_BACKWARD_AND_MODIFY_SELECTION, | |
| 50 MOVE_WORD_FORWARD, | |
| 51 MOVE_WORD_FORWARD_AND_MODIFY_SELECTION, | |
| 52 MOVE_WORD_LEFT, | |
| 53 MOVE_WORD_LEFT_AND_MODIFY_SELECTION, | |
| 54 MOVE_WORD_RIGHT, | |
| 55 MOVE_WORD_RIGHT_AND_MODIFY_SELECTION, | |
| 13 UNDO, | 56 UNDO, |
| 14 REDO, | 57 REDO, |
| 15 CUT, | 58 CUT, |
| 16 COPY, | 59 COPY, |
| 17 PASTE, | 60 PASTE, |
| 18 SELECT_ALL, | 61 SELECT_ALL, |
| 19 DELETE_FORWARD, | 62 INSERT_TEXT, |
| 20 DELETE_BACKWARD, | 63 SET_MARK, |
| 21 DELETE_TO_BEGINNING_OF_LINE, | 64 UNSELECT, |
| 22 DELETE_TO_END_OF_LINE, | 65 INVALID_COMMAND, |
|
sky
2016/06/16 16:54:09
Why do we need INVALID_COMMAND?
karandeepb
2016/06/17 07:54:14
We need a way to signal that a given TextEditComma
| |
| 23 DELETE_WORD_BACKWARD, | |
| 24 DELETE_WORD_FORWARD, | |
| 25 MOVE_LEFT, | |
| 26 MOVE_LEFT_AND_MODIFY_SELECTION, | |
| 27 MOVE_RIGHT, | |
| 28 MOVE_RIGHT_AND_MODIFY_SELECTION, | |
| 29 MOVE_WORD_LEFT, | |
| 30 MOVE_WORD_LEFT_AND_MODIFY_SELECTION, | |
| 31 MOVE_WORD_RIGHT, | |
| 32 MOVE_WORD_RIGHT_AND_MODIFY_SELECTION, | |
| 33 MOVE_TO_BEGINNING_OF_LINE, | |
| 34 MOVE_TO_BEGINNING_OF_LINE_AND_MODIFY_SELECTION, | |
| 35 MOVE_TO_END_OF_LINE, | |
| 36 MOVE_TO_END_OF_LINE_AND_MODIFY_SELECTION, | |
| 37 MOVE_UP, | |
| 38 MOVE_DOWN, | |
| 39 }; | 66 }; |
| 40 | 67 |
| 41 } // namespace ui | 68 } // namespace ui |
| 42 | 69 |
| 43 #endif // UI_BASE_IME_TEXT_EDIT_COMMANDS_H_ | 70 #endif // UI_BASE_IME_TEXT_EDIT_COMMANDS_H_ |
| OLD | NEW |
