ui/events/text_edit_commands.h - Issue 2034623002: Unify ui::TextEditCommand and ui::TextEditCommandAuraLinux::CommandId.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/events/text_edit_commands.h

Issue 2034623002: Unify ui::TextEditCommand and ui::TextEditCommandAuraLinux::CommandId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor7_correct_text_edit_command_aura_typo

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ui/events/linux/text_edit_command_auralinux.cc ('K') | « ui/events/linux/text_edit_command_auralinux.cc ('k') | ui/views/controls/textfield/textfield.cc » ('j') | ui/views/controls/textfield/textfield.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef UI_EVENTS_TEXT_EDITING_COMMANDS_H_	5 #ifndef UI_EVENTS_TEXT_EDITING_COMMANDS_H_

6 #define UI_EVENTS_TEXT_EDITING_COMMANDS_H_	6 #define UI_EVENTS_TEXT_EDITING_COMMANDS_H_

7	7

8 namespace ui {	8 namespace ui {

9	9

10 // Text editing commands for use by ui::TextInputClient.	10 // Text editing commands for use by ui::TextInputClient.

(...skipping 18 matching lines...) Expand all Loading...
29 MOVE_WORD_LEFT,	29 MOVE_WORD_LEFT,

30 MOVE_WORD_LEFT_AND_MODIFY_SELECTION,	30 MOVE_WORD_LEFT_AND_MODIFY_SELECTION,

31 MOVE_WORD_RIGHT,	31 MOVE_WORD_RIGHT,

32 MOVE_WORD_RIGHT_AND_MODIFY_SELECTION,	32 MOVE_WORD_RIGHT_AND_MODIFY_SELECTION,

33 MOVE_TO_BEGINNING_OF_LINE,	33 MOVE_TO_BEGINNING_OF_LINE,

34 MOVE_TO_BEGINNING_OF_LINE_AND_MODIFY_SELECTION,	34 MOVE_TO_BEGINNING_OF_LINE_AND_MODIFY_SELECTION,

35 MOVE_TO_END_OF_LINE,	35 MOVE_TO_END_OF_LINE,

36 MOVE_TO_END_OF_LINE_AND_MODIFY_SELECTION,	36 MOVE_TO_END_OF_LINE_AND_MODIFY_SELECTION,

37 MOVE_UP,	37 MOVE_UP,

38 MOVE_DOWN,	38 MOVE_DOWN,

	39

	40 DELETE_TO_BEGINNING_OF_PARAGRAPH,

	41 DELETE_TO_END_OF_PARAGRAPH,

	42 INSERT_TEXT,

	43 MOVE_BACKWARD,

	44 MOVE_FORWARD,

	45 MOVE_PAGE_DOWN,

	46 MOVE_PAGE_UP,

	47 MOVE_TO_BEGINNING_OF_DOCUMENT,

	48 MOVE_TO_BEGINNING_OF_PARAGRAPH,

	49 MOVE_TO_END_OF_DOCUMENT,

	50 MOVE_TO_END_OF_PARAGRAPH,

	51 MOVE_WORD_BACKWARD,

	52 MOVE_WORD_FORWARD,

	53 SET_MARK,

	54 UNSELECT,

	55

	56 MOVE_UP_AND_MODIFY_SELECTION,
	msw 2016/06/10 01:33:23 nit: ordering... keep FOO and FOO_AND_MODIFY_SELEC nit: ordering... keep FOO and FOO_AND_MODIFY_SELECTION consistently adjacent or separated. (or follow some other established order...) karandeepb 2016/06/15 08:13:34 Done. Show quoted text On 2016/06/10 01:33:23, msw wrote: > nit: ordering... keep FOO and FOO_AND_MODIFY_SELECTION consistently adjacent or > separated. (or follow some other established order...) Done.
	57 MOVE_DOWN_AND_MODIFY_SELECTION,

	58 MOVE_BACKWARD_AND_MODIFY_SELECTION,

	59 MOVE_FORWARD_AND_MODIFY_SELECTION,

	60 MOVE_PAGE_DOWN_AND_MODIFY_SELECTION,

	61 MOVE_PAGE_UP_AND_MODIFY_SELECTION,

	62 MOVE_TO_BEGINNING_OF_DOCUMENT_AND_MODIFY_SELECTION,

	63 MOVE_TO_BEGINNING_OF_PARAGRAPH_AND_MODIFY_SELECTION,

	64 MOVE_TO_END_OF_DOCUMENT_AND_MODIFY_SELECTION,

	65 MOVE_TO_END_OF_PARAGRAPH_AND_MODIFY_SELECTION,

	66 MOVE_WORD_BACKWARD_AND_MODIFY_SELECTION,

	67 MOVE_WORD_FORWARD_AND_MODIFY_SELECTION,

39 };	68 };

40	69

41 } // namespace ui	70 } // namespace ui

42	71

43 #endif // UI_EVENTS_TEXT_EDITING_COMMANDS_H_	72 #endif // UI_EVENTS_TEXT_EDITING_COMMANDS_H_

OLD	NEW