Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 2034573005: [tools/perf] Improve the regex to find the commited revision (Closed)

Created:
4 years, 6 months ago by nednguyen
Modified:
4 years, 6 months ago
Reviewers:
Zhen Wang
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tools/perf] Improve the regex to find the commited revision Add "\n" to the begin of the regex that find commit revision so we don't match text fields of the case of relanded revision got quoted. BUG=616868 TBR=zhenw@chromium.org Committed: https://crrev.com/1c2a6b9263b98d77a176fa659f0682e04473ef9a Cr-Commit-Position: refs/heads/master@{#397541}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/perf/diagnose_test_failure View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
nednguyen
4 years, 6 months ago (2016-06-02 20:40:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034573005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2034573005/1
4 years, 6 months ago (2016-06-02 23:19:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 23:28:25 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 23:30:43 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c2a6b9263b98d77a176fa659f0682e04473ef9a
Cr-Commit-Position: refs/heads/master@{#397541}

Powered by Google App Engine
This is Rietveld 408576698