Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: chrome/browser/memory/tab_manager.cc

Issue 2034573002: [Cleanup] Factor out common code. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Wherein we relearn that "commit -a" doesn't add new files. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/memory/tab_manager_unittest.cc » ('j') | chrome/browser/ui/chrome_pages.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/memory/tab_manager.cc
diff --git a/chrome/browser/memory/tab_manager.cc b/chrome/browser/memory/tab_manager.cc
index 2f491f4c042f68c7dabd6c717df2906adb35b7f3..1621b7feb35d1b4aa027e113c73628aefdf33755 100644
--- a/chrome/browser/memory/tab_manager.cc
+++ b/chrome/browser/memory/tab_manager.cc
@@ -36,6 +36,7 @@
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/browser_window.h"
+#include "chrome/browser/ui/chrome_pages.h"
#include "chrome/browser/ui/tab_contents/tab_contents_iterator.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/browser/ui/tabs/tab_utils.h"
@@ -357,24 +358,6 @@ void TabManager::PurgeMemoryAndDiscardTab() {
}
}
-// static
-bool TabManager::IsInternalPage(const GURL& url) {
- // There are many chrome:// UI URLs, but only look for the ones that users
- // are likely to have open. Most of the benefit is the from NTP URL.
- const char* const kInternalPagePrefixes[] = {
- chrome::kChromeUIDownloadsURL, chrome::kChromeUIHistoryURL,
- chrome::kChromeUINewTabURL, chrome::kChromeUISettingsURL,
- };
- // Prefix-match against the table above. Use strncmp to avoid allocating
- // memory to convert the URL prefix constants into std::strings.
- for (size_t i = 0; i < arraysize(kInternalPagePrefixes); ++i) {
- if (!strncmp(url.spec().c_str(), kInternalPagePrefixes[i],
- strlen(kInternalPagePrefixes[i])))
- return true;
- }
- return false;
-}
-
void TabManager::RecordDiscardStatistics() {
discard_count_++;
@@ -480,7 +463,7 @@ void TabManager::AddTabStats(const TabStripModel* model,
TabStats stats;
stats.is_app = is_app;
stats.is_internal_page =
- IsInternalPage(contents->GetLastCommittedURL());
+ chrome::IsInternalPage(contents->GetLastCommittedURL());
stats.is_media = IsMediaTab(contents);
stats.is_pinned = model->IsTabPinned(i);
stats.is_selected = active_model && model->IsTabSelected(i);
« no previous file with comments | « no previous file | chrome/browser/memory/tab_manager_unittest.cc » ('j') | chrome/browser/ui/chrome_pages.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698