Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Side by Side Diff: chrome/browser/ui/chrome_pages.h

Issue 2034573002: [Cleanup] Factor out common code. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Wherein we relearn that "commit -a" doesn't add new files. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/sessions/session_restore_delegate.cc ('k') | chrome/browser/ui/chrome_pages.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_CHROME_PAGES_H_ 5 #ifndef CHROME_BROWSER_UI_CHROME_PAGES_H_
6 #define CHROME_BROWSER_UI_CHROME_PAGES_H_ 6 #define CHROME_BROWSER_UI_CHROME_PAGES_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <string> 10 #include <string>
(...skipping 19 matching lines...) Expand all
30 // Keyboard accelerators. 30 // Keyboard accelerators.
31 HELP_SOURCE_KEYBOARD, 31 HELP_SOURCE_KEYBOARD,
32 32
33 // Menus (e.g. app menu or Chrome OS system menu). 33 // Menus (e.g. app menu or Chrome OS system menu).
34 HELP_SOURCE_MENU, 34 HELP_SOURCE_MENU,
35 35
36 // WebUI (the "About" page). 36 // WebUI (the "About" page).
37 HELP_SOURCE_WEBUI, 37 HELP_SOURCE_WEBUI,
38 }; 38 };
39 39
40 // Determine if a |url| points to an internal page.
41 bool IsInternalPage(const GURL& url);
sky 2016/06/02 21:46:39 'Internal' is confusing here. Why isn't chrome://o
40 42
41 void ShowBookmarkManager(Browser* browser); 43 void ShowBookmarkManager(Browser* browser);
42 void ShowBookmarkManagerForNode(Browser* browser, int64_t node_id); 44 void ShowBookmarkManagerForNode(Browser* browser, int64_t node_id);
43 void ShowHistory(Browser* browser); 45 void ShowHistory(Browser* browser);
44 void ShowDownloads(Browser* browser); 46 void ShowDownloads(Browser* browser);
45 void ShowExtensions(Browser* browser, 47 void ShowExtensions(Browser* browser,
46 const std::string& extension_to_highlight); 48 const std::string& extension_to_highlight);
47 void ShowConflicts(Browser* browser); 49 void ShowConflicts(Browser* browser);
48 50
49 // ShowFeedbackPage() uses |browser| to determine the URL of the current tab. 51 // ShowFeedbackPage() uses |browser| to determine the URL of the current tab.
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 98
97 // If the user is already signed in, shows the "Signin" portion of Settings, 99 // If the user is already signed in, shows the "Signin" portion of Settings,
98 // otherwise initiates signin in a new browser tab. 100 // otherwise initiates signin in a new browser tab.
99 void ShowBrowserSigninOrSettings(Browser* browser, 101 void ShowBrowserSigninOrSettings(Browser* browser,
100 signin_metrics::AccessPoint access_point); 102 signin_metrics::AccessPoint access_point);
101 #endif 103 #endif
102 104
103 } // namespace chrome 105 } // namespace chrome
104 106
105 #endif // CHROME_BROWSER_UI_CHROME_PAGES_H_ 107 #endif // CHROME_BROWSER_UI_CHROME_PAGES_H_
OLDNEW
« no previous file with comments | « chrome/browser/sessions/session_restore_delegate.cc ('k') | chrome/browser/ui/chrome_pages.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698