chrome/browser/tracing/navigation_tracing.cc - Issue 2034553002: Set up background memory light tracing field trials

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tracing/navigation_tracing.cc

Issue 2034553002: Set up background memory light tracing field trials (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@set_whitelist

Patch Set: Fix multiple triggers. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/trace_event/trace_config.cc ('k') | content/browser/tracing/background_tracing_config_impl.h » ('j') | content/browser/tracing/background_tracing_config_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/tracing/navigation_tracing.cc

diff --git a/chrome/browser/tracing/navigation_tracing.cc b/chrome/browser/tracing/navigation_tracing.cc

index e51d589e39bb46e277dab2a2810d71f719f631ed..1157cf80bd83e9cb674d572f9eb4f18f5efe7655 100644

--- a/chrome/browser/tracing/navigation_tracing.cc

+++ b/chrome/browser/tracing/navigation_tracing.cc

@@ -79,6 +79,18 @@ void SetupNavigationTracing() {

rules_dict->SetString("histogram_name", "V8.GCLowMemoryNotification");

rules_dict->SetInteger("trigger_delay", 5);

rules_dict->SetInteger("histogram_lower_value", 0);

+ rules_dict->SetInteger("histogram_upper_value", 250);

+ rules_list->Append(std::move(rules_dict));

+ }

+ {

+ std::unique_ptr<base::DictionaryValue> rules_dict(

+ new base::DictionaryValue());

+ rules_dict->SetString("rule",

+ "MONITOR_AND_DUMP_WHEN_SPECIFIC_HISTOGRAM_AND_VALUE");

+ rules_dict->SetString("category", "BENCHMARK_MEMORY_LIGHT");

+ rules_dict->SetString("histogram_name", "V8.GCLowMemoryNotification");

+ rules_dict->SetInteger("trigger_delay", 30);

+ rules_dict->SetInteger("histogram_lower_value", 251);

rules_dict->SetInteger("histogram_upper_value", 10000);

rules_list->Append(std::move(rules_dict));

}