Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: chrome/browser/tracing/navigation_tracing.cc

Issue 2034553002: Set up background memory light tracing field trials (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@set_whitelist
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/tracing/navigation_tracing.cc
diff --git a/chrome/browser/tracing/navigation_tracing.cc b/chrome/browser/tracing/navigation_tracing.cc
index 83f55c5fe4a597d160a5fc5fe07ba92633a770e2..b764e2b1f2e97001b9b4396fcbd589fdce5373b5 100644
--- a/chrome/browser/tracing/navigation_tracing.cc
+++ b/chrome/browser/tracing/navigation_tracing.cc
@@ -82,6 +82,18 @@ void SetupNavigationTracing() {
rules_dict->SetInteger("histogram_upper_value", 10000);
rules_list->Append(std::move(rules_dict));
}
+ {
+ std::unique_ptr<base::DictionaryValue> rules_dict(
+ new base::DictionaryValue());
+ rules_dict->SetString("rule",
+ "MONITOR_AND_DUMP_WHEN_SPECIFIC_HISTOGRAM_AND_VALUE");
+ rules_dict->SetString("category", "BENCHMARK_MEMORY_LIGHT");
+ rules_dict->SetString("histogram_name", "V8.GCLowMemoryNotification");
ssid 2016/06/02 00:14:15 Not sure why I should write the rules for low memo
oystein (OOO til 10th of July) 2016/06/02 06:11:33 Unfortunate legacy naming. Navigation tracing is w
oystein (OOO til 10th of July) 2016/06/02 06:11:33 Also: Two different trigger with the same conditio
ssid 2016/06/03 06:34:33 Sorry about this confusion. This rule shouldn't be
+ rules_dict->SetInteger("trigger_delay", 30);
+ rules_dict->SetInteger("histogram_lower_value", 0);
+ rules_dict->SetInteger("histogram_upper_value", 10000);
+ rules_list->Append(std::move(rules_dict));
+ }
dict.Set("configs", std::move(rules_list));
std::unique_ptr<content::BackgroundTracingConfig> config(

Powered by Google App Engine
This is Rietveld 408576698