Set up background memory light tracing field trials

Set up background memory light tracing field trials

This CL introduces a BENCHMARK_MEMORY_LIGHT mode for background field
trials to enable memory-infra category in BACKGROUND mode. The
background tracing controller disables the periodic memory dumps and
takes a single memory snapshot when a light preset is passed.
Since the BACKGROUND mode in memory-infra is restricted only to
whitelisted dump providers (currently empty), this tracing mode causes
very low overhead (currently none) on the user experience.

BUG=613198
Committed: https://crrev.com/8ed45166343233d13a8f3517a0b8b33d9907248f
Cr-Commit-Position: refs/heads/master@{#397910}

[ssid, 2016-06-01 23:55:55]

Patchset #1 (id:1) has been deleted

[ssid, 2016-06-02 00:06:32]

Patchset #1 (id:20001) has been deleted

[ssid, 2016-06-02 00:08:12]

Description was changed from

==========
Set up background memory light field trials

This CL introduces a BENCHMARK_MEMORY_LIGHT mode for background field
trials to enable memory-infra category in BACKGROUND mode. The
background tracing controller disables the periodic memory dumps and
takes a single memory snapshot when a low memory signal histogram value
is triggered (REACTIVE trigger).
Since the BACKGROUND mode in memory-infra is restricted only to
whitelisted dump providers (currently empty), this tracing mode causes
very low overhead (currently none) on user experience.

BUG=613198
==========

to

==========
Set up background memory light tracing field trials

This CL introduces a BENCHMARK_MEMORY_LIGHT mode for background field
trials to enable memory-infra category in BACKGROUND mode. The
background tracing controller disables the periodic memory dumps and
takes a single memory snapshot when a low memory signal histogram value
is triggered (REACTIVE trigger).
Since the BACKGROUND mode in memory-infra is restricted only to
whitelisted dump providers (currently empty), this tracing mode causes
very low overhead (currently none) on user experience.

BUG=613198
==========

[ssid, 2016-06-02 00:09:01]

Description was changed from

==========
Set up background memory light tracing field trials

This CL introduces a BENCHMARK_MEMORY_LIGHT mode for background field
trials to enable memory-infra category in BACKGROUND mode. The
background tracing controller disables the periodic memory dumps and
takes a single memory snapshot when a low memory signal histogram value
is triggered (REACTIVE trigger).
Since the BACKGROUND mode in memory-infra is restricted only to
whitelisted dump providers (currently empty), this tracing mode causes
very low overhead (currently none) on user experience.

BUG=613198
==========

to

==========
Set up background memory light tracing field trials

This CL introduces a BENCHMARK_MEMORY_LIGHT mode for background field
trials to enable memory-infra category in BACKGROUND mode. The
background tracing controller disables the periodic memory dumps and
takes a single memory snapshot when a low memory signal histogram value
is triggered (REACTIVE trigger).
Since the BACKGROUND mode in memory-infra is restricted only to
whitelisted dump providers (currently empty), this tracing mode causes
very low overhead (currently none) on the user experience.

BUG=613198
==========

[ssid, 2016-06-02 00:14:14]

ssid@chromium.org changed reviewers:
+ oysteine@chromium.org, primiano@chromium.org

[ssid, 2016-06-02 00:14:15]

Now, that we have a whitelist of dump providers, the field trial for
memory-infra background can be set up. I am guessing that this still needs to be
enabled using the field trial server later, and that will be done after enabling
few dump providers and going through launch review. For the current situation
does this CL look good?

https://codereview.chromium.org/2034553002/diff/40001/chrome/browser/tracing/...
File chrome/browser/tracing/navigation_tracing.cc (right):

https://codereview.chromium.org/2034553002/diff/40001/chrome/browser/tracing/...
chrome/browser/tracing/navigation_tracing.cc:91:
rules_dict->SetString("histogram_name", "V8.GCLowMemoryNotification");
Not sure why I should write the rules for low memory trigger inside
"navigation_tracing" file. How are they related?

[oystein (OOO til 10th of July), 2016-06-02 06:11:33]

https://codereview.chromium.org/2034553002/diff/40001/chrome/browser/tracing/...
File chrome/browser/tracing/navigation_tracing.cc (right):

https://codereview.chromium.org/2034553002/diff/40001/chrome/browser/tracing/...
chrome/browser/tracing/navigation_tracing.cc:91:
rules_dict->SetString("histogram_name", "V8.GCLowMemoryNotification");
On 2016/06/02 00:14:15, ssid wrote:
> Not sure why I should write the rules for low memory trigger inside
> "navigation_tracing" file. How are they related?

Unfortunate legacy naming. Navigation tracing is what deep reports is called in
the about://flags entry, even though there's nothing in the system that
restricts it to navigation traces; it's just what it was initially used for. It
should probably be renamed, if someone can come up with a good alternative :).

https://codereview.chromium.org/2034553002/diff/40001/chrome/browser/tracing/...
chrome/browser/tracing/navigation_tracing.cc:91:
rules_dict->SetString("histogram_name", "V8.GCLowMemoryNotification");
Also: Two different trigger with the same conditions won't work; the second one
to trigger will stop the trace. Maybe the histogram values to trigger on can be
two discrete ranges, if this is to test the pipeline?

https://codereview.chromium.org/2034553002/diff/40001/content/browser/tracing...
File content/browser/tracing/background_tracing_manager_impl.cc (right):

https://codereview.chromium.org/2034553002/diff/40001/content/browser/tracing...
content/browser/tracing/background_tracing_manager_impl.cc:49: // Tracing
enabled callback for BENCHMARK_MEMORY_LIGHT category preset.
Maybe add a TODO that the special-casing here should be replaced once we can add
arbitrary TraceConfig stuffs to the background tracing config.

[ssid, 2016-06-03 06:34:33]

ptal, thanks.

https://codereview.chromium.org/2034553002/diff/40001/chrome/browser/tracing/...
File chrome/browser/tracing/navigation_tracing.cc (right):

https://codereview.chromium.org/2034553002/diff/40001/chrome/browser/tracing/...
chrome/browser/tracing/navigation_tracing.cc:91:
rules_dict->SetString("histogram_name", "V8.GCLowMemoryNotification");
On 2016/06/02 06:11:33, Oystein wrote:
> Also: Two different trigger with the same conditions won't work; the second
one
> to trigger will stop the trace. Maybe the histogram values to trigger on can
be
> two discrete ranges, if this is to test the pipeline?

Sorry about this confusion. This rule shouldn't be in navigation tracing file. I
will later add this if needed.

https://codereview.chromium.org/2034553002/diff/40001/content/browser/tracing...
File content/browser/tracing/background_tracing_manager_impl.cc (right):

https://codereview.chromium.org/2034553002/diff/40001/content/browser/tracing...
content/browser/tracing/background_tracing_manager_impl.cc:49: // Tracing
enabled callback for BENCHMARK_MEMORY_LIGHT category preset.
On 2016/06/02 06:11:33, Oystein wrote:
> Maybe add a TODO that the special-casing here should be replaced once we can
add
> arbitrary TraceConfig stuffs to the background tracing config.

Done.

[Primiano Tucci (use gerrit), 2016-06-03 16:04:20]

I am not too familiar with this code so really can't help a low with reviews.
Only one things bump to my eyes, looks like we are doing some workarounds
because we don't have traceconfig.
It is fine, but at this point can we add an extra check to MDM, something like
MemoryDumpManager::GetInstance()->SetAllowOnlyBackgroundMode(bool) which rejects
completely any non background dump request? I just fear that if we screw up
something in this traceconfig mangling in future we end up starting the default
periodic full dump behavior.
It should be a 3 lines change, and we can remove it after we have the proper
plumbing.

[ssid, 2016-06-03 21:17:24]

On 2016/06/03 16:04:20, Primiano Tucci wrote:
> I am not too familiar with this code so really can't help a low with reviews.
> Only one things bump to my eyes, looks like we are doing some workarounds
> because we don't have traceconfig.
> It is fine, but at this point can we add an extra check to MDM, something like
> MemoryDumpManager::GetInstance()->SetAllowOnlyBackgroundMode(bool) which
rejects
> completely any non background dump request? I just fear that if we screw up
> something in this traceconfig mangling in future we end up starting the
default
> periodic full dump behavior.
> It should be a 3 lines change, and we can remove it after we have the proper
> plumbing.

Good point, I have filed a bug for that: crbug.com/617208.
Will fix it in next CL. It shouldn't be an issue right now because no one
actually uses request memory dump in code base.

[oystein (OOO til 10th of July), 2016-06-03 22:09:19]

lgtm! (with the code in navigation_tracing.cc removed, as mentioned).

https://codereview.chromium.org/2034553002/diff/60001/content/browser/tracing...
File content/browser/tracing/background_tracing_config_impl.cc (right):

https://codereview.chromium.org/2034553002/diff/60001/content/browser/tracing...
content/browser/tracing/background_tracing_config_impl.cc:120: }
ubernit: newline to be consistent

[ssid, 2016-06-03 22:36:21]

On 2016/06/03 22:09:19, Oystein wrote:
> lgtm! (with the code in navigation_tracing.cc removed, as mentioned).
Sorry, actually removed this now.

https://codereview.chromium.org/2034553002/diff/60001/content/browser/tracing...
File content/browser/tracing/background_tracing_config_impl.cc (right):

https://codereview.chromium.org/2034553002/diff/60001/content/browser/tracing...
content/browser/tracing/background_tracing_config_impl.cc:120: }
On 2016/06/03 22:09:18, Oystein wrote:
> ubernit: newline to be consistent

Done.

[ssid, 2016-06-03 22:38:45]

Description was changed from

==========
Set up background memory light tracing field trials

This CL introduces a BENCHMARK_MEMORY_LIGHT mode for background field
trials to enable memory-infra category in BACKGROUND mode. The
background tracing controller disables the periodic memory dumps and
takes a single memory snapshot when a low memory signal histogram value
is triggered (REACTIVE trigger).
Since the BACKGROUND mode in memory-infra is restricted only to
whitelisted dump providers (currently empty), this tracing mode causes
very low overhead (currently none) on the user experience.

BUG=613198
==========

to

==========
Set up background memory light tracing field trials

This CL introduces a BENCHMARK_MEMORY_LIGHT mode for background field
trials to enable memory-infra category in BACKGROUND mode. The
background tracing controller disables the periodic memory dumps and
takes a single memory snapshot when a light preset is passed.
Since the BACKGROUND mode in memory-infra is restricted only to
whitelisted dump providers (currently empty), this tracing mode causes
very low overhead (currently none) on the user experience.

BUG=613198
==========

[ssid, 2016-06-04 00:42:12]

The CQ bit was checked by ssid@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-04 00:43:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2034553002/100001

[commit-bot: I haz the power, 2016-06-04 03:13:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-04 03:13:53]

Dry run: This issue passed the CQ dry run.

[ssid, 2016-06-04 08:09:41]

The CQ bit was checked by ssid@chromium.org

[ssid, 2016-06-04 08:09:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
oysteine@chromium.org
Link to the patchset: https://codereview.chromium.org/2034553002/#ps100001
(title: "Remove navigation_tracing change and add base_export.")

[ssid, 2016-06-04 08:09:44]

The CQ bit was unchecked by ssid@chromium.org

[ssid, 2016-06-04 08:10:04]

The CQ bit was checked by ssid@chromium.org

[commit-bot: I haz the power, 2016-06-04 08:10:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2034553002/100001

[commit-bot: I haz the power, 2016-06-04 08:13:41]

Description was changed from

==========
Set up background memory light tracing field trials

This CL introduces a BENCHMARK_MEMORY_LIGHT mode for background field
trials to enable memory-infra category in BACKGROUND mode. The
background tracing controller disables the periodic memory dumps and
takes a single memory snapshot when a light preset is passed.
Since the BACKGROUND mode in memory-infra is restricted only to
whitelisted dump providers (currently empty), this tracing mode causes
very low overhead (currently none) on the user experience.

BUG=613198
==========

to

==========
Set up background memory light tracing field trials

This CL introduces a BENCHMARK_MEMORY_LIGHT mode for background field
trials to enable memory-infra category in BACKGROUND mode. The
background tracing controller disables the periodic memory dumps and
takes a single memory snapshot when a light preset is passed.
Since the BACKGROUND mode in memory-infra is restricted only to
whitelisted dump providers (currently empty), this tracing mode causes
very low overhead (currently none) on the user experience.

BUG=613198
==========

[commit-bot: I haz the power, 2016-06-04 08:13:43]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2016-06-04 08:15:05]

Description was changed from

==========
Set up background memory light tracing field trials

This CL introduces a BENCHMARK_MEMORY_LIGHT mode for background field
trials to enable memory-infra category in BACKGROUND mode. The
background tracing controller disables the periodic memory dumps and
takes a single memory snapshot when a light preset is passed.
Since the BACKGROUND mode in memory-infra is restricted only to
whitelisted dump providers (currently empty), this tracing mode causes
very low overhead (currently none) on the user experience.

BUG=613198
==========

to

==========
Set up background memory light tracing field trials

This CL introduces a BENCHMARK_MEMORY_LIGHT mode for background field
trials to enable memory-infra category in BACKGROUND mode. The
background tracing controller disables the periodic memory dumps and
takes a single memory snapshot when a light preset is passed.
Since the BACKGROUND mode in memory-infra is restricted only to
whitelisted dump providers (currently empty), this tracing mode causes
very low overhead (currently none) on the user experience.

BUG=613198

Committed: https://crrev.com/8ed45166343233d13a8f3517a0b8b33d9907248f
Cr-Commit-Position: refs/heads/master@{#397910}
==========

[commit-bot: I haz the power, 2016-06-04 08:15:06]

Patchset 4 (id:??) landed as
https://crrev.com/8ed45166343233d13a8f3517a0b8b33d9907248f
Cr-Commit-Position: refs/heads/master@{#397910}