Retry icon fetching after intent_helper is ready

components/arc/intent_helper/link_handler_model_impl.cc

Index: components/arc/intent_helper/link_handler_model_impl.cc
diff --git a/components/arc/intent_helper/link_handler_model_impl.cc b/components/arc/intent_helper/link_handler_model_impl.cc
index 4f9896795f62eec016c4598542810ac6be64af79..2ba9f227a658252adc31ac30a14eff02ce83f204 100644
--- a/components/arc/intent_helper/link_handler_model_impl.cc
+++ b/components/arc/intent_helper/link_handler_model_impl.cc
@@ -115,9 +115,11 @@ void LinkHandlerModelImpl::OnUrlHandlerList(
       activities.emplace_back(handlers_[i]->package_name,
                               handlers_[i]->activity_name);
     }
-    icon_info_notified = icon_loader_->GetActivityIcons(
+    const ActivityIconLoader::GetResult result = icon_loader_->GetActivityIcons(
         activities, base::Bind(&LinkHandlerModelImpl::NotifyObserver,
                                weak_ptr_factory_.GetWeakPtr()));
+    icon_info_notified =
+        (result != ActivityIconLoader::GetResult::SUCCEEDED_ASYNC);

[Luis Héctor Chávez, 2016/06/02 16:59:47]

Isn't the intention "result == ActivityIconLoader::GetResult::SUCCEEDED_SYNC"?

[Yusuke Sato, 2016/06/02 18:03:19]

GetResult::FAILED_* also run the callback actually. Updated the
ActivityIconLoader function comment.

[Luis Héctor Chávez, 2016/06/02 20:03:51]

Makes more sense now :)

nit: Can you add a small function in ActivityIconLoader that encapsulates this
logic and give it a useful name that indicates that the callback has been
triggered to avoid future confusion?

[Yusuke Sato, 2016/06/02 21:07:27]

Great idea, done.

   }
 
   if (!icon_info_notified) {