Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Unified Diff: components/arc/intent_helper/activity_icon_loader_unittest.cc

Issue 2034543003: Retry icon fetching after intent_helper is ready (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/arc/intent_helper/activity_icon_loader_unittest.cc
diff --git a/components/arc/intent_helper/activity_icon_loader_unittest.cc b/components/arc/intent_helper/activity_icon_loader_unittest.cc
index 4504e0d7270e112636fe849c3c1300d617eb98aa..e56d68dee92dc6692300f66e7024e3aac14a347f 100644
--- a/components/arc/intent_helper/activity_icon_loader_unittest.cc
+++ b/components/arc/intent_helper/activity_icon_loader_unittest.cc
@@ -89,17 +89,20 @@ TEST(ActivityIconLoaderTest, TestGetActivityIcons) {
activities.emplace_back("p0", "a0");
activities.emplace_back("p1", "a1");
activities.emplace_back("p1", "a0");
- EXPECT_TRUE(loader->GetActivityIcons(activities, base::Bind(&OnIconsReady0)));
+ EXPECT_EQ(ActivityIconLoader::GetResult::SUCCEEDED_SYNC,
+ loader->GetActivityIcons(activities, base::Bind(&OnIconsReady0)));
// Test with different |activities|.
activities.clear();
activities.emplace_back("p1", "a1");
- EXPECT_TRUE(loader->GetActivityIcons(activities, base::Bind(&OnIconsReady1)));
+ EXPECT_EQ(ActivityIconLoader::GetResult::SUCCEEDED_SYNC,
+ loader->GetActivityIcons(activities, base::Bind(&OnIconsReady1)));
activities.clear();
+ EXPECT_EQ(ActivityIconLoader::GetResult::SUCCEEDED_SYNC,
+ loader->GetActivityIcons(activities, base::Bind(&OnIconsReady2)));
activities.emplace_back("p1", "a_unknown");
- EXPECT_TRUE(loader->GetActivityIcons(activities, base::Bind(&OnIconsReady2)));
- activities.clear();
- EXPECT_TRUE(loader->GetActivityIcons(activities, base::Bind(&OnIconsReady2)));
+ EXPECT_EQ(ActivityIconLoader::GetResult::FAILED_ARC_NOT_SUPPORTED,
+ loader->GetActivityIcons(activities, base::Bind(&OnIconsReady2)));
}
// Tests if OnIconsResized updates the cache.
« no previous file with comments | « components/arc/intent_helper/activity_icon_loader.cc ('k') | components/arc/intent_helper/link_handler_model_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698