Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2034543002: Clear UIThreadExtensionFunction::render_frame_host_ when RFH is gone. (Closed)

Created:
4 years, 6 months ago by lazyboy
Modified:
4 years, 6 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clear UIThreadExtensionFunction::render_frame_host_ when RFH is gone. This regressed in my CL r395494 where I mistakenly put a short circuit in SetRenderFrameHost. SetRenderFrameHost is called with nullptr RFH when WebContentsObserver::RenderFrameDeleted() happens (for non service worker case). BUG=616119 Test=See clusterfuzz repro, it infrequently reproduces though. But I was able to verify with this CL that the crash shouldn't happen. Committed: https://crrev.com/fd6715d5469aaa2fa05bc3ab316767d6ea84867e Cr-Commit-Position: refs/heads/master@{#397432}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
M extensions/browser/extension_function.h View 2 chunks +8 lines, -0 lines 0 comments Download
M extensions/browser/extension_function.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M extensions/browser/extension_function_dispatcher.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
lazyboy
4 years, 6 months ago (2016-06-01 23:40:24 UTC) #3
Devlin
lgtm
4 years, 6 months ago (2016-06-02 00:16:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2034543002/1
4 years, 6 months ago (2016-06-02 01:00:57 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/221943) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 6 months ago (2016-06-02 02:10:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2034543002/1
4 years, 6 months ago (2016-06-02 15:06:16 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 16:08:43 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 16:10:40 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd6715d5469aaa2fa05bc3ab316767d6ea84867e
Cr-Commit-Position: refs/heads/master@{#397432}

Powered by Google App Engine
This is Rietveld 408576698