Issue 203453002: Promises: make null a legal argument for .then

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 203453002: Promises: make null a legal argument for .then (Closed)

Created:
6 years, 9 months ago by rossberg

Modified:
6 years, 9 months ago

Reviewers:
Sven Panne

CC:
v8-dev, yhirano

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Promises: make null a legal argument for .then R=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=20037

Patch Set 1 #

Total comments: 2

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -10 lines)			Patch
	M	src/promise.js	View		3 chunks	+10 lines, -8 lines	2 comments	Download
	M	test/mjsunit/es6/promises.js	View		2 chunks	+12 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

lgtm https://codereview.chromium.org/203453002/diff/1/src/promise.js File src/promise.js (right): https://codereview.chromium.org/203453002/diff/1/src/promise.js#newcode236 src/promise.js:236: } catch(r) { Let me guess why you ...

6 years, 9 months ago (2014-03-18 14:46:17 UTC) #1

rossberg

https://codereview.chromium.org/203453002/diff/1/src/promise.js File src/promise.js (right): https://codereview.chromium.org/203453002/diff/1/src/promise.js#newcode236 src/promise.js:236: } catch(r) { On 2014/03/18 14:46:18, Sven Panne wrote: ...

6 years, 9 months ago (2014-03-18 14:48:20 UTC) #2

rossberg

6 years, 9 months ago (2014-03-18 14:55:49 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r20037 (presubmit successful).

Expand Messages | Collapse Messages